Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sylius API on API Platform #11250

Open
5 of 12 tasks
lchrusciel opened this issue Mar 18, 2020 · 5 comments
Open
5 of 12 tasks

New Sylius API on API Platform #11250

lchrusciel opened this issue Mar 18, 2020 · 5 comments
Labels
API APIs related issues and PRs. Help Wanted Issues needing help and clarification. RFC Discussions about potential changes or new features.

Comments

@lchrusciel
Copy link
Member

lchrusciel commented Mar 18, 2020

This issue is created to coordinate efforts and have one space to reference to all of the PR's aiming to provide API platform support for Sylius.

Sylius API Architecture

Every time you will contribute to Sylius API please, take into account the following decisions (ADRs):

If you would like to add something there feel free to open a new proposal :)

This effort is being done in the current Sylius master branch. Please help us with testing what's been done, by using the API locally 🚀

TODO for the community - Admin API coverage

If you can't wait to see Sylius with the full API Platform support, feel more than welcome to help us with it. All of these will require to have behat coverage (@ui tagged scenarios run also tagged as @api) to merge them to master.

  • Locales [API] add locale to Api Platform #11273
    All the features from features/locale/managing_locales
    2 scenarios / 3 files
    Create an index action only (show may be required as well)

  • Association Types [API] product association type #11319
    All the features from: features/product/managing_product_association_types
    12 scenarios / 8 files
    Full CRUD for options and values + validation and filtering

  • Countries [API] add country #11278, [Countries][API] cover non-empty province name validation #11431
    All the features from features/addressing/managing_countries
    15 scenarios / 8 files
    Full CRUD for countries and provinces + validation

  • Zones [API] Zones #11372
    All the features from features/addressing/managing_zones
    20 scenarios, 7 files
    Full CRUD
    Ensure proper zone type validation

  • Taxonomies
    All the features from features/taxonomy
    47 scenarios, 14 files
    Full CRUD
    Only features with @ui and without @todo tag

  • Channels [API] adding and browsing Channel #11417, [API] deleting and editing Channel #11486
    All the features from features/user/managing_channels
    35 scenarios, 19 files (16 scenarios/4 files already done)
    Full CRUD

  • Tax rates Cover managing the tax rates in API #14811
    All the features from features/taxation/managing_tax_rates
    18 scenarios, 6 files
    Full CRUD

  • Modifying Order's address
    All the features from features/order/managing_orders/modifying_billing_address and features/order/managing_orders/modifying_shipping_address
    18 scenarios, 10 files

  • Filtering on the Orders list
    All the features from features/order/managing_orders/order_filtration
    12 scenarios, 3 files

  • Order details
    All the features from features/order/managing_orders/order_details
    30 scenarios, 22 files

  • Browsing orders
    All the features from features/order/managing_orders/browsing_orders
    8 scenarios, 6 files

  • Handling shipments and payments
    All the features from features/order/managing_orders/handling_order_payment and features/order/managing_orders/handling_order_shipment
    15 scenarios, 7 files

If you will cover some of the features above, let us know, so the effort will not be duplicated. More features will be added in the nearest future

@lchrusciel lchrusciel added RFC Discussions about potential changes or new features. Help Wanted Issues needing help and clarification. API APIs related issues and PRs. Roadmap labels Mar 18, 2020
This was referenced Mar 18, 2020
GSadee added a commit that referenced this issue Sep 24, 2020
…mKasp)

This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no/yes
| New feature?    | no/yes
| BC breaks?      | no/yes
| Deprecations?   | no
| Related tickets | part of #11250, based on #11872 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.7 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

5109de8 [Account][API] Edititng customer profile with validation
b7a06a6 [Customer][Api] restrict access to customer for proper users
GSadee added a commit that referenced this issue Oct 1, 2020
This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Related tickets | part of #11250 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.7 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

e1c7504 [API] orders index in customer account
c5231fe [API] cover viewing order by customer
0416f17 [Api][Account] orders index - improvements
GSadee added a commit that referenced this issue Oct 21, 2020
This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Related tickets | part of #11250 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.7 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

3788aae [Api] Change payment method after checkout
41582c7 [API][Payments] change endpoints and add missing specs
e94b15e Refactor change payment methods behats
33eeea3 [API][Payment Method] Refactor choose payment method handler
0be4481 Refactor orderItemMethodExtension
@pjedrzejewski
Copy link
Member

@lchrusciel WDYT about renaming this issue to indicate that it's an invitation to contribute to the Admin API? I reference it in the meta-issue about the overall effort: #12466

lchrusciel added a commit that referenced this issue Jul 16, 2021
…scenarios (lchrusciel)

This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Part of #11250
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

6bc0d75 [Behat][API][Taxes] Turn on chunk of taxation scenarios
ad4b1a8 [Behat][API][Shiipin] Turn on chunk of shipping scenarios with taxation
GSadee added a commit that referenced this issue Jul 16, 2021
…narios (lchrusciel)

This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Part of #11250
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

0fa2e48 [Behat][API][Promotion] Turn on chunk of promotion scenarios
@zairigimad
Copy link
Contributor

Hello, Is there a plan to add the Inventory to the API?

@vvasiloi
Copy link
Contributor

Hello,
The Admin API also had endpoints for managing the customers (docs).
Should it be added to the list?
It looks like it's not covered by Behat tests: https://github.com/Sylius/Sylius/tree/4e37f162c8fad574ef5a459ec7c941f1e6d20a7f/features/user/managing_customers

NoResponseMate added a commit that referenced this issue Apr 25, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

I added a taxon delete section.

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | part of #11250                     |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

65f39f2 Add a taxon delete section

I added a taxon delete section.
GSadee added a commit that referenced this issue Jun 9, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets | part of #11250 |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

76d5102 [API] Sorting user orders by order number
7ac1948 Added tests to sorting user orders
4c0d93a Fixes for a conversation
GSadee pushed a commit to Sylius/SyliusApiBundle that referenced this issue Aug 11, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

I added a taxon delete section.

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | part of Sylius/Sylius#11250                     |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

65f39f2057b951e71b9cd2578270e963ce55ec66 Add a taxon delete section

I added a taxon delete section.
GSadee added a commit to Sylius/SyliusApiBundle that referenced this issue Aug 11, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets | part of Sylius/Sylius#11250 |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

76d51022f3070bce5fdb7f9eb1810fff3300eb3c [API] Sorting user orders by order number
7ac19488f5b35c5b2ce12e317446ae91d3eee34f Added tests to sorting user orders
4c0d93a601427ee5a0ca7bdad4a8863731a100ee Fixes for a conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Help Wanted Issues needing help and clarification. RFC Discussions about potential changes or new features.
Projects
None yet
Development

No branches or pull requests

7 participants