[API] JWT Authentication #11174
[API] JWT Authentication #11174
Conversation
Zales0123
commented
Mar 4, 2020
Zales0123
commented
| Q | A |
|---|---|
| Branch? | api |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Zales0123
force-pushed
the
api-authorization
branch
from
6d4342f
to
78dd1f4
Compare
| print_header "Setting up JWT for API" "Sylius" | ||
| run_command "source .env.test" | ||
| run_command "openssl genrsa -out config/jwt/private-test.pem 4096 -algorithm rsa -passout env:JWT_PASSPHRAS rsa_keygen_bits:4096" | ||
| run_command "openssl pkey -in config/jwt/private-test.pem -out config/jwt/public-test.pem -pubout" |
There was a problem hiding this comment.
Should we expose this in our docs?
There was a problem hiding this comment.
But as we don't have any docs for the new API right now (instead of swagger which, maybe, is enough 💃) I would add it later 🚀
There was a problem hiding this comment.
That's one of the problems that people may have issues with running and testing it :( Let's move with this PR, but we need to provide this note in the installation guide.
There was a problem hiding this comment.
Both private-test.pem and public-test.pem (for test environment) could be included in the repository
on .gitignore
!config/jwt/*-test.pem
There was a problem hiding this comment.
Hey Loic, could you open a PR with fix?
Zales0123
force-pushed
the
api-authorization
branch
from
c7fb1ee
to
6d14d40
Compare
Zales0123
force-pushed
the
api-authorization
branch
from
8a847be
to
2ddaf24
Compare
| ); | ||
| $defaultHeaders = ['HTTP_ACCEPT' => 'application/ld+json']; | ||
| if ($this->sharedStorage->has('token')) { | ||
| $defaultHeaders['HTTP_Authorization'] = 'Bearer ' . $this->sharedStorage->get('token'); |
There was a problem hiding this comment.
| $defaultHeaders['HTTP_Authorization'] = 'Bearer ' . $this->sharedStorage->get('token'); | |
| $defaultHeaders['HTTP_Authorization'] = 'Bearer ' . $this->sharedStorage->get('securiity_token'); |
|
Thanks, Mateusz! 🥇 |
|
Part of #11250 |
