Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Browsing payments #11206

Merged
merged 3 commits into from
Mar 11, 2020
Merged

[API] Browsing payments #11206

merged 3 commits into from
Mar 11, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 10, 2020

Q A
Branch? api
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added Feature New feature proposals. Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels Mar 10, 2020
@GSadee GSadee requested a review from a team as a code owner March 10, 2020 15:09
@Zales0123 Zales0123 merged commit d78c837 into Sylius:api Mar 11, 2020
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the api-payment branch March 11, 2020 08:29
Tomanhez
Tomanhez reviewed Mar 11, 2020
View reviewed changes
src/Sylius/Behat/Client/ApiPlatformClient.php
Comment on lines +166 to +172
/** @param string|int $value */
public function relatedResourceHasValue(string $resource, string $key, $value): bool
{
$this->showRelated($resource);

return $this->getResponseContentValue($key) === $value;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong order , I guess this method should be above public function responseHasValue(string $key, $value): bool

@lchrusciel
Copy link
Member

Part of #11250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@Tomanhez Tomanhez Tomanhez left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @Zales0123 @lchrusciel @Tomanhez