Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Refactor ApiPlatformClient ver.2 #11220

Merged
merged 2 commits into from
Mar 13, 2020
Merged

[API] Refactor ApiPlatformClient ver.2 #11220

merged 2 commits into from
Mar 13, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 13, 2020

Q A
Branch? api
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT
  • refactor filters
  • add returning Response object to methods that make a request

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Behat Issues and PRs aimed at improving Behat usage. API APIs related issues and PRs. labels Mar 13, 2020
@GSadee GSadee requested a review from a team as a code owner March 13, 2020 11:36
lchrusciel
lchrusciel approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next stage, we could remove almost all getLastResponse() calls

@lchrusciel lchrusciel merged commit e21e847 into Sylius:api Mar 13, 2020
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the refactor-api-client branch March 13, 2020 12:33
@GSadee GSadee mentioned this pull request Mar 13, 2020
Merged
lchrusciel added a commit that referenced this pull request Mar 13, 2020
@lchrusciel
refactor #11224 [API][Behat] Minor contexts refactor (GSadee)
8830a89 
This PR was merged into the api branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | api
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | after #11220
| License         | MIT


Commits
-------

a7e26e7 [API][Behat] Minor contexts refactor
@lchrusciel
Copy link
Member

Part of #11250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @lchrusciel @Zales0123 @AdamKasp