Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add tax rates to Api Platform #11884

Closed
wants to merge 7 commits into from
Closed

Conversation

hatem20
Copy link
Contributor

@hatem20 hatem20 commented Sep 28, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets partially #11250
License MIT
  • adding_tax_rate.feature
  • deleting_tax_rate.feature
  • deleting_multiple_tax_rates.feature
  • tax_rate_unique_code_validation.feature
  • tax_rate_validation.feature
  • editing_tax_rate.feature

@hatem20 hatem20 requested a review from a team as a code owner September 28, 2020 23:56
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 28, 2020
@hatem20 hatem20 force-pushed the api-tax-rates branch 7 times, most recently from d2cf0ce to 62535c0 Compare October 3, 2020 00:18
@hatem20 hatem20 changed the title [WIP][API] Add tax rates to Api Platform [API] Add tax rates to Api Platform Feb 10, 2021
@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Jun 26, 2021
@jakubtobiasz
Copy link
Contributor

Hi @hatem20 🙋🏼‍♂️!
Using your work, we created the #14811 PR, where we're going to continue this work (I had to rebase and made some adjustments). Of course, all commits created by you are marked as created by you :).

GSadee added a commit that referenced this pull request Feb 23, 2023
…iasz)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | successor of #11884                      |
| License         | MIT                                                          |


Commits
-------

03c3438 [Tax rate][Behat] Add include tax rate step in add tax feature
f84fce7 [API][Tax rate] Implement adding_tax_rate feature
c8fe3b3 [API][Tax rate] Implement deleting_tax_rate feature
e147639 [API][Tax rate] Implement deleting_multiple_tax_rates feature
bacef86 [API][Tax rate] Implement tax_rate_unique_code_validation feature
161d25d [API][Tax rate] Implement tax_rate_validation feature
7cdf3e7 [API][Tax rate] Implement editing_tax_rate feature
cff62a6 Adjust Tax Rates API related Behat scenarios to the new standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Stale Issues and PRs with no recent activity, about to be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants