Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Product options vol.2 #11157

Merged
merged 2 commits into from
Feb 28, 2020
Merged

[API] Product options vol.2 #11157

merged 2 commits into from
Feb 28, 2020

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Feb 27, 2020 •
edited by pamil

Q A
Branch? api
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets started in #11136, continuation of #11144
License MIT
  • production option name validation
  • default sorting of product options

@Zales0123 Zales0123 added Feature New feature proposals. API APIs related issues and PRs. labels Feb 27, 2020
@Zales0123 Zales0123 requested a review from a team as a code owner February 27, 2020 09:50
@GSadee GSadee merged commit f65b3ef into Sylius:api Feb 28, 2020
@GSadee
Copy link
Member

GSadee commented Feb 28, 2020

Thank you, Mateusz! 🥇

@Zales0123 Zales0123 deleted the product-options-api-update-vol-2 branch February 29, 2020 08:00
@lchrusciel
Copy link
Member

Part of #11250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zales0123 @GSadee @lchrusciel