[API] Sorting user orders by order number #14990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dawkaa
commented
Apr 26, 2023
•
dawkaa
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | part of #11250 |
| License | MIT |
jakubtobiasz
previously approved these changes
May 1, 2023
features/order/managing_orders/browsing_orders/sorting_orders_by_number.feature
Show resolved
Hide resolved
coldic3
reviewed
May 12, 2023
dawkaa
force-pushed
the
dev
branch
4 times, most recently
from
568cab5
to
9016d16
Compare
NoResponseMate
previously approved these changes
Jun 8, 2023
I did sorting user orders by order number.
I added tests to sorting user orders.
I added the fixes for the conversation.
GSadee
approved these changes
Jun 9, 2023
| /** | ||
| * @Then I should see an order with :orderNumber number | ||
| */ | ||
| public function iShouldSeeOrderWithNumber(string $orderNumber) |
| /** | ||
| * @When I switch the way orders are sorted by :fieldName | ||
| */ | ||
| public function iSwitchSortingBy($fieldName) |
There was a problem hiding this comment.
Missing type hint and return type
| } | ||
|
|
||
| /** | ||
| * @When I switch the way orders are sorted by :fieldName |
There was a problem hiding this comment.
It would be good to keep the order of the methods: Given -> When -> Then, so this one should be moved before Then method, which is above
|
Thanks, Dawka! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.