Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable arbitrary try builds #124631

Merged
merged 4 commits into from May 5, 2024
Merged

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 2, 2024

This PR should enable running arbitrary try builds with @bors try. So far there is no support for this in bors! You would need to manually add a special line (see below) to the PR description (this will later be automated with new bors).

try-job: aarch64-gnu
try-job: arm-android

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 2, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented May 2, 2024

@bors try

@bors
Copy link
Contributor

bors commented May 2, 2024

⌛ Trying commit b5a9405 with merge d07ee6e...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2024
CI: enable arbitrary try build

This PR should enable running arbitrary try builds with ``@bors` try`. So far there is no support for this in bors! You would need to manually add a line containing `ci-job: <job-name>` to the message of the latest commit of the PR (this will later be automated with new bors).

r? `@ghost`
@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 2, 2024

@bors try

@rust-log-analyzer

This comment has been minimized.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2024
CI: enable arbitrary try build

This PR should enable running arbitrary try builds with ``@bors` try`. So far there is no support for this in bors! You would need to manually add a special line (see below) containing to the PR description (this will later be automated with new bors).

ci-job: aarch64-gnu

r? `@ghost`
@bors
Copy link
Contributor

bors commented May 2, 2024

⌛ Trying commit b5a9405 with merge 119362f...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented May 2, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2024
@Kobzol
Copy link
Contributor Author

Kobzol commented May 2, 2024

@bors try

@bors
Copy link
Contributor

bors commented May 2, 2024

⌛ Trying commit 334c6ef with merge f81cd9d...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2024
CI: enable arbitrary try build

This PR should enable running arbitrary try builds with ``@bors` try`. So far there is no support for this in bors! You would need to manually add a special line (see below) containing to the PR description (this will later be automated with new bors).

ci-job: aarch64-gnu

r? `@ghost`
@Kobzol
Copy link
Contributor Author

Kobzol commented May 2, 2024

@bors try

@bors
Copy link
Contributor

bors commented May 2, 2024

⌛ Trying commit 92a3052 with merge 4fe69d8...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2024
CI: enable arbitrary try build

This PR should enable running arbitrary try builds with ``@bors` try`. So far there is no support for this in bors! You would need to manually add a special line (see below) containing to the PR description (this will later be automated with new bors).

ci-job: aarch64-gnu
ci-job: arm-android

r? `@ghost`
@Kobzol Kobzol marked this pull request as ready for review May 2, 2024 20:25
@Kobzol
Copy link
Contributor Author

Kobzol commented May 2, 2024

r? pietroalbini

I will document this in rustc-dev-guide after it's merged.

@Kobzol Kobzol changed the title CI: enable arbitrary try build CI: enable arbitrary try builds May 2, 2024
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2024
@pietroalbini
Copy link
Member

Yay!

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented May 3, 2024

📌 Commit fc218f2 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2024
@bors
Copy link
Contributor

bors commented May 5, 2024

⌛ Testing commit fc218f2 with merge d9d6315...

@bors
Copy link
Contributor

bors commented May 5, 2024

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing d9d6315 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2024
@bors bors merged commit d9d6315 into rust-lang:master May 5, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 5, 2024
@matthiaskrgr
Copy link
Member

@bors treeclosed=9999 ci is completely broken and no longer checks for failure

@matthiaskrgr
Copy link
Member

looks like since this PR; bors insta-merges everything unconditionally

@matthiaskrgr
Copy link
Member

@bors treeclosed=9999

bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2024
…albini

CI: enable arbitrary try builds, take two

Fixed version of rust-lang#124631, which hopefully won't completely break our CI this time 🤦‍♂️ Sorry once again. Only the last commit is new.

r? `@pietroalbini`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 11, 2024
CI: enable arbitrary try builds, take two

Fixed version of rust-lang/rust#124631, which hopefully won't completely break our CI this time 🤦‍♂️ Sorry once again. Only the last commit is new.

r? `@pietroalbini`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants