Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for arbitrary try builds #80

Closed
Kobzol opened this issue May 2, 2024 · 0 comments · Fixed by #85
Closed

Implement support for arbitrary try builds #80

Kobzol opened this issue May 2, 2024 · 0 comments · Fixed by #85
Labels
help wanted We would appreciate help from contributors

Comments

@Kobzol
Copy link
Contributor

Kobzol commented May 2, 2024

With rust-lang/rust#124631, the rust CI will be able to run an arbitrary CI job in a try build. It would be great to add support for this in bors.

Arbitrary try build CI jobs are parsed from a special line with the format try-job: <job-name>, which should be in the commit message of the latest commit on the PR. Currently, bors sets the Auto merge commit message to the PR description, so users have to modify it. With new bors, it should instead append these special lines directly to the merge commit message.

Steps:

  1. Extend the parsing of a @bors try command so that it will be able to receive the names of arbitrary CI jobs.
    Something like @bors try jobs=<name1>,<name2>,...
  2. For each job name in the command, output a single line with the contents try-job: <job-name> to the commit message of the try build

And that's pretty much it. We could also implement some sanity checks, e.g. if the user specifies 50 jobs, bors should error out (rust-lang/rust#124631 currently allows specifying 10 jobs max.).

@Kobzol Kobzol added the help wanted We would appreciate help from contributors label May 2, 2024
@Kobzol Kobzol closed this as completed in #85 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We would appreciate help from contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant