Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Enable the brand new triagebot transfer command #124725

Merged
merged 1 commit into from
May 5, 2024
Merged

Meta: Enable the brand new triagebot transfer command #124725

merged 1 commit into from
May 5, 2024

Conversation

fmease
Copy link
Member

@fmease fmease commented May 4, 2024 •
edited

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the A-meta Area: Issues about the rust-lang/rust repository. label May 4, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 4, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2024
fmease
fmease commented May 4, 2024
View reviewed changes
triagebot.toml
@@ -1057,3 +1057,7 @@ project-exploit-mitigations = [
# Enable tracking of PR review assignment
# Documentation at: https://forge.rust-lang.org/triagebot/pr-assignment-tracking.html
[pr-tracking]

# Enable issue transfers within the org
# Documentation at: https://forge.rust-lang.org/triagebot/transfer.html
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Location doesn't exist yet, depends on rust-lang/rust-forge#741. The URL is unlikely to change I'd say, so not blocking imo.

@fmease
Copy link
Member Author

fmease commented May 4, 2024

@bors rollup

@matthiaskrgr
Copy link
Member

👀 I'm wondering what happens if we try to transfer a pullrequest.

@fmease
Copy link
Member Author

fmease commented May 4, 2024 •
edited

@matthiaskrgr, it will error out: https://github.com/rust-lang/triagebot/blob/da0d5acdf5412bf246b79aa7b3c9c3168ddb640a/src/handlers/transfer.rs#L14-L19

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 4, 2024
Merged
@jackh726
Copy link
Member

jackh726 commented May 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented May 4, 2024

📌 Commit 94f922a has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2024
fmease added a commit to fmease/rust that referenced this pull request May 5, 2024
@fmease
Rollup merge of rust-lang#124725 - fmease:enable-triagebot-transfer, …
0fb7ede 
…r=jackh726

Meta: Enable the brand new triagebot transfer command

cc rust-lang/triagebot#1780, rust-lang/rust-forge#741, https://github.com/rust-lang/rust/issues/124619#issuecomment-2094258528
cc `@ehuss,` `@jackh726`
@fmease fmease mentioned this pull request May 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
@bors
Auto merge of rust-lang#124730 - fmease:rollup-uciy8d8, r=fmease
7dd00c3 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122253 (Support Result<T, E> across FFI when niche optimization can be used)
 - rust-lang#123892 (Document That `f16` And `f128` Hardware Support is Limited)
 - rust-lang#124458 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+))
 - rust-lang#124459 (Stabilize exclusive_range_pattern)
 - rust-lang#124711 (Migrate `run-make/doctests-runtool` to rmake)
 - rust-lang#124725 (Meta: Enable the brand new triagebot transfer command)
 - rust-lang#124727 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2024
@bors
Auto merge of rust-lang#124730 - fmease:rollup-uciy8d8, r=fmease
e0ffdd9 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122253 (Support Result<T, E> across FFI when niche optimization can be used)
 - rust-lang#123892 (Document That `f16` And `f128` Hardware Support is Limited)
 - rust-lang#124458 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+))
 - rust-lang#124459 (Stabilize exclusive_range_pattern)
 - rust-lang#124711 (Migrate `run-make/doctests-runtool` to rmake)
 - rust-lang#124725 (Meta: Enable the brand new triagebot transfer command)
 - rust-lang#124727 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented May 5, 2024

⌛ Testing commit 94f922a with merge 69ffc0d...

@bors
Copy link
Contributor

bors commented May 5, 2024

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 69ffc0d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2024
@bors bors merged commit 69ffc0d into rust-lang:master May 5, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 5, 2024
@fmease fmease deleted the enable-triagebot-transfer branch May 5, 2024 09:07
@Kobzol
Copy link
Contributor

Kobzol commented May 5, 2024

This PR has been merged by accident, without the full test suite being run. It was my fault (#124631 got merged and it broke our CI). @fmease Could you please create a new PR with your branch against the latest version of origin/master? Thank you, and sorry for the mess.

@fmease fmease mentioned this pull request May 5, 2024
Merged
@dtolnay
Copy link
Member

dtolnay commented May 5, 2024

New PR: #124768

fmease added a commit to fmease/rust that referenced this pull request May 5, 2024
@fmease
Rollup merge of rust-lang#124768 - fmease:enable-triagebot-transfer-2…
31e2302 
…, r=jackh726

[resubmission] Meta: Enable the brand new triagebot transfer command

rust-lang#124725, rust-lang#124725 (comment)

r? ghost
fmease added a commit to fmease/rust that referenced this pull request May 5, 2024
@fmease
Rollup merge of rust-lang#124768 - fmease:enable-triagebot-transfer-2…
f599c0a 
…, r=jackh726

[resubmission] Meta: Enable the brand new triagebot transfer command

rust-lang#124725, rust-lang#124725 (comment)

r? ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#124768 - fmease:enable-triagebot-transfer-2…
cce0fdf 
…, r=jackh726

[resubmission] Meta: Enable the brand new triagebot transfer command

rust-lang#124725, rust-lang#124725 (comment)

r? ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#124768 - fmease:enable-triagebot-transfer-2…
78ee4ce 
…, r=jackh726

[resubmission] Meta: Enable the brand new triagebot transfer command

rust-lang#124725, rust-lang#124725 (comment)

r? ghost
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2024
@rust-timer
Unrolled build for rust-lang#124768
d949519 
Rollup merge of rust-lang#124768 - fmease:enable-triagebot-transfer-2, r=jackh726

[resubmission] Meta: Enable the brand new triagebot transfer command

rust-lang#124725, rust-lang#124725 (comment)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues about the rust-lang/rust repository. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fmease @rustbot @matthiaskrgr @jackh726 @bors @Kobzol @dtolnay @Mark-Simulacrum