-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsafe extern blocks #124482
Unsafe extern blocks #124482
Conversation
|
This comment has been minimized.
This comment has been minimized.
Ohh I forgot to mention this. I'd need to land some PRs, at least to stdarch so it doesn't warn for the usages of |
eff0aa5
to
4db4aac
Compare
This comment has been minimized.
This comment has been minimized.
4db4aac
to
109be86
Compare
This comment has been minimized.
This comment has been minimized.
109be86
to
429a626
Compare
This comment has been minimized.
This comment has been minimized.
429a626
to
b4828d8
Compare
This comment has been minimized.
This comment has been minimized.
b4828d8
to
e7d5d4e
Compare
This comment has been minimized.
This comment has been minimized.
e7d5d4e
to
cc91d7f
Compare
This comment has been minimized.
This comment has been minimized.
cc91d7f
to
542a307
Compare
This comment has been minimized.
This comment has been minimized.
542a307
to
7b82197
Compare
This comment has been minimized.
This comment has been minimized.
7b82197
to
8f0c075
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me.
Have a look at the See for example this test. |
Added this too!. |
2b54f41
to
525828d
Compare
@bors r+ |
@bors rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2d28b63): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.766s -> 672.761s (-0.00%) |
This adds a new feature, so a small regression is probably to be expected. Marking as triaged. @rustbot label: +perf-regression-triaged |
👍, anyway there's a pre-existing issue in the way we use ItemKind and convert to ForeignItemKind for the sake of code reuse that this PR made slightly worser and may cause such small perf regression. I have this in my todo list to address. |
…li-obk Unsafe extern blocks This implements RFC 3484. Tracking issue rust-lang#123743 and RFC rust-lang/rfcs#3484 This is better reviewed commit by commit.
This implements RFC 3484.
Tracking issue #123743 and RFC rust-lang/rfcs#3484
This is better reviewed commit by commit.