Support Result<T, E> across FFI when niche optimization can be used #122253

MasterAwesome · 2024-03-09T20:13:08Z

Allow allow enums like Result<T, E> to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe.

Implementation of rust-lang/rfcs#3391
Tracking issue: #110503

Additional ABI and codegen tests were added in #115372

rustbot · 2024-03-09T20:13:16Z

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

cjgillot · 2024-03-10T13:05:17Z

r? compiler

petrochenkov · 2024-03-12T14:27:38Z

Hmmm.
r? @RalfJung

RalfJung · 2024-03-12T16:15:01Z

Sorry, I can't review these lint implementations.
Maybe r? @davidtwco ; I see you've worked on the improper-ctypes lint in the past.

compiler/rustc_lint/src/types.rs

tests/ui/lint/lint-ctypes-enum.rs

compiler/rustc_lint/src/types.rs

bors · 2024-04-23T02:41:28Z

☔ The latest upstream changes (presumably #124271) made this pull request unmergeable. Please resolve the merge conflicts.

davidtwco

r=me after rebasing

Allow allow enums like `Result<T, E>` to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe.

Fields are disallowed so checking the top attribute is enough.

MasterAwesome · 2024-04-24T04:33:39Z

@bors r=davidtwco

bors · 2024-04-24T04:33:42Z

@MasterAwesome: 🔑 Insufficient privileges: Not in reviewers

MasterAwesome · 2024-04-24T04:36:23Z

I guess I don't have permissions @davidtwco, can you queue this in?

Dylan-DPC · 2024-05-01T13:21:24Z

@bors r=davidtwco

bors · 2024-05-01T13:21:27Z

📌 Commit ed532cc has been approved by davidtwco

It is now in the queue for this repository.

bors · 2024-05-01T13:22:39Z

⌛ Testing commit ed532cc with merge 4d96c3e...

Support Result<T, E> across FFI when niche optimization can be used Allow allow enums like `Result<T, E>` to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe. Implementation of rust-lang/rfcs#3391 Tracking issue: rust-lang#110503 Additional ABI and codegen tests were added in rust-lang#115372

fmease · 2024-05-03T01:51:09Z

⌛ Testing commit ed532cc with merge 4d96c3e...

That's a zombie.

@bors retry for good measure.

Support Result<T, E> across FFI when niche optimization can be used Allow allow enums like `Result<T, E>` to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe. Implementation of rust-lang/rfcs#3391 Tracking issue: rust-lang#110503 Additional ABI and codegen tests were added in rust-lang#115372

Rollup of 7 pull requests Successful merges: - rust-lang#122253 (Support Result<T, E> across FFI when niche optimization can be used) - rust-lang#123892 (Document That `f16` And `f128` Hardware Support is Limited) - rust-lang#124458 (Implement lldb formattter for "clang encoded" enums (LLDB 18.1+)) - rust-lang#124459 (Stabilize exclusive_range_pattern) - rust-lang#124711 (Migrate `run-make/doctests-runtool` to rmake) - rust-lang#124725 (Meta: Enable the brand new triagebot transfer command) - rust-lang#124727 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-05-05T04:35:15Z

⌛ Testing commit ed532cc with merge 654afe3...

bors · 2024-05-05T04:36:55Z

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 654afe3 to master...

Kobzol · 2024-05-05T12:12:31Z

This PR has been merged by accident, without the full test suite being run. It was my fault (#124631 got merged and it broke our CI). @MasterAwesome Could you please create a new PR with your branch against the latest version of origin/master? Thank you, and sorry for the mess.

dtolnay · 2024-05-05T13:43:42Z

New PR, from the same branch: #124747

Support Result<T, E> across FFI when niche optimization can be used (v2) This PR is identical to rust-lang#122253, which was approved and merged but then removed from master by a force-push due to a [CI bug](https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/ci.20broken.3F). r? ghost Original PR description: --- Allow allow enums like `Result<T, E>` to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe. Implementation of rust-lang/rfcs#3391 Tracking issue: rust-lang#110503 Additional ABI and codegen tests were added in rust-lang#115372

rustbot assigned cjgillot Mar 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2024

This comment has been minimized.

Sign in to view

MasterAwesome marked this pull request as ready for review March 9, 2024 22:36

This comment has been minimized.

Sign in to view

rustbot assigned petrochenkov and unassigned cjgillot Mar 10, 2024

rustbot assigned RalfJung and unassigned petrochenkov Mar 12, 2024

rustbot assigned davidtwco and unassigned RalfJung Mar 12, 2024

RalfJung mentioned this pull request Mar 12, 2024

Tracking Issue for result_ffi_guarantees (RFC 3391) #110503

Open

3 tasks

davidtwco requested changes Mar 18, 2024

View reviewed changes

compiler/rustc_lint/src/types.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/types.rs Outdated Show resolved Hide resolved

tests/ui/lint/lint-ctypes-enum.rs Show resolved Hide resolved

compiler/rustc_lint/src/types.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024

MasterAwesome requested a review from davidtwco March 19, 2024 03:32

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2024

MasterAwesome force-pushed the master branch from e937929 to 56c5435 Compare March 31, 2024 20:29

davidtwco approved these changes Apr 23, 2024

View reviewed changes

MasterAwesome added 3 commits April 23, 2024 21:15

Support Result<T, E> across FFI when niche optimization can be used

fc37633

Allow allow enums like `Result<T, E>` to be used across FFI if the T/E can be niche optimized and the non-niche-optimized type is FFI safe.

We don't need to check for non-exhaustive fields

b3e6d52

Fields are disallowed so checking the top attribute is enough.

Don't lint niche optimized variants in enums

08b85a1

MasterAwesome added 3 commits April 23, 2024 21:27

Reword is_niche_optimization_candidate doc

764f64f

Remove comment out of RFC's scope

437ca26

Put the RFC behind a feature gate result_ffi_guarantees

ed532cc

MasterAwesome force-pushed the master branch from 56c5435 to ed532cc Compare April 24, 2024 04:31

MasterAwesome requested a review from davidtwco April 29, 2024 23:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2024

fmease mentioned this pull request May 5, 2024

Rollup of 7 pull requests #124730

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2024

bors merged commit 654afe3 into rust-lang:master May 5, 2024
13 checks passed

rustbot added this to the 1.80.0 milestone May 5, 2024

dtolnay mentioned this pull request May 5, 2024

Support Result<T, E> across FFI when niche optimization can be used (v2) #124747

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Result<T, E> across FFI when niche optimization can be used #122253

Support Result<T, E> across FFI when niche optimization can be used #122253

MasterAwesome commented Mar 9, 2024 •

edited

rustbot commented Mar 9, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjgillot commented Mar 10, 2024

petrochenkov commented Mar 12, 2024

RalfJung commented Mar 12, 2024

bors commented Apr 23, 2024

davidtwco left a comment

MasterAwesome commented Apr 24, 2024

bors commented Apr 24, 2024

MasterAwesome commented Apr 24, 2024

Dylan-DPC commented May 1, 2024

bors commented May 1, 2024

bors commented May 1, 2024

fmease commented May 3, 2024

bors commented May 5, 2024

bors commented May 5, 2024

Kobzol commented May 5, 2024

dtolnay commented May 5, 2024

Support Result<T, E> across FFI when niche optimization can be used #122253

Support Result<T, E> across FFI when niche optimization can be used #122253

Conversation

MasterAwesome commented Mar 9, 2024 • edited

rustbot commented Mar 9, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjgillot commented Mar 10, 2024

petrochenkov commented Mar 12, 2024

RalfJung commented Mar 12, 2024

bors commented Apr 23, 2024

davidtwco left a comment

Choose a reason for hiding this comment

MasterAwesome commented Apr 24, 2024

bors commented Apr 24, 2024

MasterAwesome commented Apr 24, 2024

Dylan-DPC commented May 1, 2024

bors commented May 1, 2024

bors commented May 1, 2024

fmease commented May 3, 2024

bors commented May 5, 2024

bors commented May 5, 2024

Kobzol commented May 5, 2024

dtolnay commented May 5, 2024

MasterAwesome commented Mar 9, 2024 •

edited