Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly #1365

Merged
merged 26 commits into from
Jun 18, 2024

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners May 30, 2024 03:16
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 67.40741% with 88 lines in your changes missing coverage. Please review.

Project coverage is 70.56%. Comparing base (b9d6a55) to head (2cd2091).
Report is 11 commits behind head on develop.

Current head 2cd2091 differs from pull request most recent head 00251a9

Please upload reports for the commit 00251a9 to get more accurate results.

Files Patch % Lines
pkg/generic/generic_service.go 58.13% 14 Missing and 4 partials ⚠️
pkg/generic/generic.go 76.92% 8 Missing and 4 partials ⚠️
pkg/generic/thrift/json.go 0.00% 10 Missing ⚠️
pkg/generic/proto/json.go 0.00% 8 Missing ⚠️
pkg/generic/httppbthrift_codec.go 50.00% 7 Missing ⚠️
pkg/generic/jsonthrift_codec.go 72.00% 5 Missing and 2 partials ⚠️
pkg/generic/thrift/struct.go 36.36% 6 Missing and 1 partial ⚠️
pkg/generic/httpthrift_codec.go 85.71% 4 Missing and 1 partial ⚠️
pkg/generic/jsonpb_codec.go 68.75% 4 Missing and 1 partial ⚠️
pkg/generic/thrift/http.go 50.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1365      +/-   ##
===========================================
+ Coverage    70.43%   70.56%   +0.13%     
===========================================
  Files          293      293              
  Lines        21155    21196      +41     
===========================================
+ Hits         14900    14957      +57     
- Misses        5017     5018       +1     
+ Partials      1238     1221      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/generic/generic.go Outdated Show resolved Hide resolved
pkg/remote/codec/util.go Outdated Show resolved Hide resolved
@Marina-Sakai Marina-Sakai force-pushed the refactor/generic branch 2 times, most recently from 2857956 to 14c6206 Compare June 4, 2024 09:03
AsterDY
AsterDY previously approved these changes Jun 5, 2024
AsterDY
AsterDY previously approved these changes Jun 10, 2024
@Marina-Sakai Marina-Sakai changed the title WIP: refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly Jun 18, 2024
@Marina-Sakai Marina-Sakai merged commit a45de35 into cloudwego:develop Jun 18, 2024
20 checks passed
@Marina-Sakai Marina-Sakai deleted the refactor/generic branch June 18, 2024 06:27
Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jun 24, 2024
…which has the generic's reader and writer info directly (cloudwego#1365)
Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jun 24, 2024
…iceInfo which has the generic's reader and writer info directly (cloudwego#1365)"

This reverts commit a45de35.
Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jun 24, 2024
…which has the generic's reader and writer info directly (cloudwego#1365)
joway pushed a commit to joway/kitex that referenced this pull request Jun 24, 2024
…which has the generic's reader and writer info directly (cloudwego#1365)
Marina-Sakai added a commit to Marina-Sakai/kitex that referenced this pull request Jun 25, 2024
…which has the generic's reader and writer info directly (cloudwego#1365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants