Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly #1365

Merged
merged 26 commits into from
Jun 18, 2024
Merged

refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly #1365

merged 26 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. json thrift generic refactor

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    be37e5e View commit details
    Browse the repository at this point in the history

  2. json pb refactor

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    31f1276 View commit details
    Browse the repository at this point in the history

  3. map and http thrift generic

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    52fa792 View commit details
    Browse the repository at this point in the history

  4. http pb thrift generic refactor

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    77c660a View commit details
    Browse the repository at this point in the history

  5. add err handling

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cd1ec84 View commit details
    Browse the repository at this point in the history

  6. test: add and fix tests

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    93507aa View commit details
    Browse the repository at this point in the history

  7. fix: nit things

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a53e276 View commit details
    Browse the repository at this point in the history

  8. fix: jsonthrift codec test

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7696efa View commit details
    Browse the repository at this point in the history

  9. fix: lint

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1a11169 View commit details
    Browse the repository at this point in the history

  10. fix: import

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5374913 View commit details
    Browse the repository at this point in the history

  11. fix: revert unnecessary files

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5ce39d3 View commit details
    Browse the repository at this point in the history

  12. fix: import

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    95764d1 View commit details
    Browse the repository at this point in the history

  13. fix: import lint

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3671fe0 View commit details
    Browse the repository at this point in the history

  14. fix: pass method and isClient to writer and reader

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4548064 View commit details
    Browse the repository at this point in the history

  15. fix: typo

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7515622 View commit details
    Browse the repository at this point in the history

  16. fix: make a TODO for binary generic multi-service

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2e3ea5b View commit details
    Browse the repository at this point in the history

  17. revert: reserve the old APIs and leave comments

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6d927e2 View commit details
    Browse the repository at this point in the history

  18. fix: arguments

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d2df168 View commit details
    Browse the repository at this point in the history

  19. fix: review dog

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a569add View commit details
    Browse the repository at this point in the history

  20. fix: no need to check cause ttheader doesn't pass idlSvcName when it'… 

    …s GenericService
    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cc0c758 View commit details
    Browse the repository at this point in the history

  21. fix: lint

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0f12dd5 View commit details
    Browse the repository at this point in the history

  22. fix: better use method

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a8efdb0 View commit details
    Browse the repository at this point in the history

  23. chore: todo -> note

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d80b2ab View commit details
    Browse the repository at this point in the history

  24. refactor: remove codecInfo from serviceInfo

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7921251 View commit details
    Browse the repository at this point in the history

  25. refactor: no need isClient

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5978061 View commit details
    Browse the repository at this point in the history

  26. refactor: no need isClient

    @Marina-Sakai
    Marina-Sakai committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    00251a9 View commit details
    Browse the repository at this point in the history