fix: revert unnecessary files

cloudwego · May 30, 2024 · cf95bfc · cf95bfc
1 parent 9c3cb83
commit cf95bfc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/pkg/generic/generic.go b/pkg/generic/generic.go
@@ -265,7 +265,6 @@ func (g *jsonThriftGeneric) PayloadCodecType() serviceinfo.PayloadCodec {
 
 func (g *jsonThriftGeneric) PayloadCodec() remote.PayloadCodec {
  return nil
- //return g.codec
 }
 
 func (g *jsonThriftGeneric) GetMethod(req interface{}, method string) (*Method, error) {

diff --git a/pkg/generic/httpthrift_codec_test.go b/pkg/generic/httpthrift_codec_test.go
@@ -66,7 +66,7 @@ func TestHttpThriftCodec(t *testing.T) {
  test.Assert(t, htc.GetIDLServiceName() == "ExampleService")
 
  rw := htc.GetMessageReaderWriter()
- err, ok := rw.(error)
+ _, ok := rw.(error)
  test.Assert(t, !ok)
 
  htc.SetMethod(method.Name)

diff --git a/pkg/generic/mapthrift_codec.go b/pkg/generic/mapthrift_codec.go
@@ -17,6 +17,7 @@
 package generic
 
 import (
+ "github.com/pkg/errors"
  "sync/atomic"
 
  "github.com/cloudwego/kitex/pkg/generic/descriptor"
@@ -74,8 +75,7 @@ func (c *mapThriftCodec) update() {
 func (c *mapThriftCodec) GetMessageReaderWriter() interface{} {
  svcDsc, ok := c.svcDsc.Load().(*descriptor.ServiceDescriptor)
  if !ok {
- return nil
- //return nil, fmt.Errorf("get parser ServiceDescriptor failed")
+ return errors.New("get parser ServiceDescriptor failed")
  }
  var rw *thrift.StructReaderWriter
  var err error