Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generic): refactor existing generic to have new ServiceInfo which has the generic's reader and writer info directly #1408

Conversation

Marina-Sakai
Copy link
Contributor

…which has the generic's reader and writer info directly (#1365)

What type of PR is this?

refactor (cherry-pick)

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

…which has the generic's reader and writer info directly (cloudwego#1365)
@Marina-Sakai Marina-Sakai requested review from a team as code owners June 24, 2024 01:46
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 50.52632% with 188 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v0.11.0@ccdb750). Learn more about missing BASE report.

Current head 1398979 differs from pull request most recent head 79ba047

Please upload reports for the commit 79ba047 to get more accurate results.

Files Patch % Lines
pkg/generic/thrift/json.go 0.00% 35 Missing ⚠️
pkg/generic/httppbthrift_codec.go 16.66% 25 Missing ⚠️
pkg/generic/generic_service.go 55.10% 18 Missing and 4 partials ⚠️
pkg/generic/thrift/json_go116plus_amd64.go 0.00% 19 Missing ⚠️
pkg/generic/mapthrift_codec.go 68.29% 11 Missing and 2 partials ⚠️
pkg/generic/jsonthrift_codec.go 66.66% 10 Missing and 2 partials ⚠️
pkg/generic/generic.go 71.42% 10 Missing ⚠️
pkg/generic/jsonpb_codec.go 56.52% 8 Missing and 2 partials ⚠️
pkg/generic/httpthrift_codec.go 70.96% 8 Missing and 1 partial ⚠️
pkg/generic/thrift/http_go116plus_amd64.go 12.50% 7 Missing ⚠️
... and 7 more
Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.11.0    #1408   +/-   ##
==================================================
  Coverage                   ?   70.29%           
==================================================
  Files                      ?      296           
  Lines                      ?    21227           
  Branches                   ?        0           
==================================================
  Hits                       ?    14921           
  Misses                     ?     5085           
  Partials                   ?     1221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marina-Sakai Marina-Sakai merged commit 8203ebb into cloudwego:release-v0.11.0 Jun 24, 2024
20 checks passed
@Marina-Sakai Marina-Sakai deleted the cherry-pick/refactor_generic branch June 24, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants