{pre,post}-build: use actions/{upload,download}-artifact@v4

[ZhongRuoyu]

Companion to Homebrew/brew#17097.

Tested in ZhongRuoyu/homebrew-test#44.

Fixes #475.

[Bo98]

Looks great, thanks for this!

[Bo98]

Given the failed bottle name change: is there a concern for pr-pull glob matching existing runs? Might want to prioritise bottles over bottles-* if it exists.

[ZhongRuoyu]

Given the failed bottle name change: is there a concern for pr-pull glob matching existing runs? Might want to prioritise bottles over bottles-* if it exists.

Yes, was just thinking about this too. This is a real concern and we should avoid failed bottles generated from existing runs get accidentally picked up. Prioritising bottles seems to be a nice solution so that we won't have problems during migration.

[ZhongRuoyu]

Actually, this also brings problems to the bottle cache workflow. We could probably just choose a different pattern. I'll go with bottles_* instead. Then we could still do bottles{,_*}.

[ZhongRuoyu]

Suggested change

	pattern: bottles{,_*}
	pattern: bottles_*

Because v4 cannot download v3 artifacts anyway, according to https://github.com/actions/download-artifact/tree/v4/#v4---whats-new.

This affects dependent testing, which means some of the ongoing CI jobs will fail when this is merged. Preferably the long timeout jobs should be at dep testing (i.e., after bottles are downloaded) when merging this.

[Bo98]

pr-pull uses REST API which wraps v3 and v4 that part is probably OK at least.

But yeah, for dep testing it's perhaps best to time this for when the CI queue is empty. I can also watch out for that opportunity similarly if needed.

[Bo98]

actions/download-artifact in the homebrew-core dispatch-* workflows will also need updating after merging

[MikeMcQuaid]

Thanks again @ZhongRuoyu!

[ZhongRuoyu]

Now seems to be a good time to merge this. Long-timeout jobs have both started dep testing.

[carlocab]

🚢