pr-pull: support globbing artifacts #17097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
changed the title
Artifact actions v3 is deprecated and will soon be unavailable [^1]. This adds support for v4 by allowing `brew pr-pull` to accept a glob pattern for artifact names, like actions/download-artifact does [^2]. [^1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ [^2]: https://github.com/actions/download-artifact/tree/v4/#usage
ZhongRuoyu
force-pushed
the
artifact-actions-v4
branch
from
348412b
to
d6d1b7d
Compare
ZhongRuoyu
commented
Apr 16, 2024
ZhongRuoyu
force-pushed
the
artifact-actions-v4
branch
from
90bb789
to
135db8c
Compare
Bo98
reviewed
Apr 16, 2024
MikeMcQuaid
approved these changes
Apr 17, 2024
Note to anyone coming here later: this is the reason that deprecating this command-line argument doesn't make sense here. This is going to be broken soon due to reasons outside of Homebrew's control. |
|
Merge order and note:
The two PRs above should work with existing v3 artifacts too because they only involve the REST APIs.
|
|
Merging. Will then try to test some PRs in core for each PR merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Artifact actions v3 is deprecated and will soon be unavailable 1. This adds support for v4 by allowing
brew pr-pullto accept a glob pattern for artifact names, like actions/download-artifact does 2.Footnotes
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ ↩
https://github.com/actions/download-artifact/tree/v4/#usage ↩