Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch-{build-,re}bottle: use actions/download-artifact@v4 #169270

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Companion to Homebrew/actions#529.

@ZhongRuoyu ZhongRuoyu requested review from MikeMcQuaid and a team as code owners April 17, 2024 06:11
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Apr 17, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @ZhongRuoyu!

@chenrui333 chenrui333 added this pull request to the merge queue Apr 17, 2024
@chenrui333 chenrui333 removed this pull request from the merge queue due to a manual request Apr 17, 2024
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Apr 18, 2024
Merged via the queue into master with commit ca904d2 Apr 18, 2024
19 checks passed
@ZhongRuoyu ZhongRuoyu deleted the artifact-actions-v4 branch April 18, 2024 15:28
@github-actions github-actions bot added the outdated PR was locked due to age label May 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants