Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{pre,post}-build: use actions/{upload,download}-artifact@v4 #529

Merged
merged 6 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions post-build/action.yml
Expand Up @@ -49,9 +49,9 @@ runs:

- name: Upload logs
if: always()
uses: actions/upload-artifact@v3-node20
uses: actions/upload-artifact@v4
with:
name: logs-${{ inputs.runner }}
name: logs_${{ inputs.runner }}
path: ${{ inputs.logs-directory }}

- name: Count bottles
Expand All @@ -63,16 +63,16 @@ runs:

- name: Upload failed bottles
if: always() && steps.bottles.outputs.failures > 0
uses: actions/upload-artifact@v3-node20
uses: actions/upload-artifact@v4
with:
name: bottles-${{ inputs.runner }}
name: failed-bottles_${{ inputs.runner }}
path: ${{ inputs.bottles-directory }}/failed

- name: Upload list of successfully tested dependents
if: always() && !fromJson(inputs.upload-bottles) && steps.bottles.outputs.dependents > 0
uses: actions/upload-artifact@v3-node20
uses: actions/upload-artifact@v4
with:
name: dependents
name: dependents_${{ inputs.runner }}
path: ${{ inputs.bottles-directory }}/tested-dependents-*.txt
MikeMcQuaid marked this conversation as resolved.
Show resolved Hide resolved

# Must be run before the `Upload bottles` step so that failed
Expand All @@ -87,9 +87,9 @@ runs:

- name: Upload bottles
if: always() && fromJson(inputs.upload-bottles) && (steps.bottles.outputs.count > 0 || steps.bottles.outputs.skipped > 0)
uses: actions/upload-artifact@v3-node20
uses: actions/upload-artifact@v4
with:
name: bottles
name: bottles_${{ inputs.runner }}
path: ${{ inputs.bottles-directory }}

- name: Post cleanup
Expand Down
5 changes: 3 additions & 2 deletions pre-build/action.yml
Expand Up @@ -67,7 +67,8 @@ runs:

- name: Download bottles from GitHub Actions
if: fromJson(inputs.download-bottles)
uses: actions/download-artifact@v3-node20
uses: actions/download-artifact@v4
with:
name: bottles
pattern: bottles_*
path: ${{ inputs.bottles-directory }}
merge-multiple: true