Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint v9 #9002

Merged
merged 30 commits into from May 12, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 26, 2024

👉 NOTE: This is into our v8 branch. Once it's merged, it'll only be included in our v8 versions.

PR Checklist

Overview

Keeps us on ESLint v8 internally, but adds v9 to the supported version ranges. Adds a CI check that yarn add eslint@9; yarn test passes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 26, 2024 13:40
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ee1d91c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/663ce10214bbb100085ba99f
😎 Deploy Preview https://deploy-preview-9002--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Apr 26, 2024

packages/eslint-plugin/package.json Outdated Show resolved Hide resolved
packages/parser/package.json Outdated Show resolved Hide resolved
packages/rule-tester/package.json Outdated Show resolved Hide resolved
packages/type-utils/package.json Outdated Show resolved Hide resolved
packages/typescript-eslint/package.json Outdated Show resolved Hide resolved
packages/utils/package.json Outdated Show resolved Hide resolved
packages/integration-tests/fixtures/eslint-v8/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 🏆

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we really want to do the bump to v9 if it completely breaks our lint setup like this?
would we be better served by instead just adding a decent integration test which runs against v9, and leaving our setup on v8 for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran yarn dedupe to trim this file down a bit. Then I reverted the tmp upgrades as they cause a few odd CI failures. #8589

@RobinTail

This comment has been minimized.

@JoshuaKGoldberg JoshuaKGoldberg merged commit b765f7b into typescript-eslint:v8 May 12, 2024
62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-9 branch May 12, 2024 23:30
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented May 13, 2024

Now that this is merged, the v8 versions of typescript-eslint starting with v8.0.0-alpha.10 now support ESLint v9. Hooray! 🙌

If you still have problems with typescript-eslint and ESLint v9:

  1. Please make sure you're using [email protected] or newer
  2. Go through our issue chooser to file a new issue reporting your problems
    • That issue template includes searching for existing issues matching your problem - please do not file duplicate issues

Note that we do not plan on backporting ESLint v9 support to v7 versions of typescript-eslint. There are a lot of breaking changes inherent to our ESLint v9 support.

If any enterprising individual wants to try onboarding us in typescript-eslint to ESLint v9, #9082 tracks that as a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants