Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for eslint 9 #1

Open
Santalov opened this issue Apr 27, 2024 · 4 comments
Open

Support for eslint 9 #1

Santalov opened this issue Apr 27, 2024 · 4 comments

Comments

@Santalov
Copy link

This project comes with eslint config out of the box.

But eslint is not listed in the project deps. So running lint script errors.

The next obvious step is to install eslint

yarn add eslint

But by default latest version of the eslint is installed (eslint 9), which is incompatible with current config file. So developer meets unobvious errors which is a little frustrating.

You can see the first details about new config format here.
And some examples are here https://stackoverflow.com/questions/74237042/how-to-correctly-configure-the-parser-plugins-with-eslints-new-flat-config

I suggest eslint configuration should be removed or updated to meet the latest version of eslint.

@heyqbnk
Copy link
Member

heyqbnk commented Apr 29, 2024

Hey. Missing eslint package seems like a bug.

I am not sure we can switch to eslint@9 as long as it seems rather new for now and some of the plugins are not ready for a new major version.

Nevertheless, we can possibly recognize current eslint configuration as too subjective and remove all plugins just leaving only those, necessary for working with TypeScript. So, we would use some config like eslint/recommended. In this case, we can switch to eslint9.

What do you think about it? In case, its fine, could you create a PR proposing changes?

@Santalov
Copy link
Author

What do you think about it? In case, its fine, could you create a PR proposing changes?

Sounds good. Will create one in a day or so

@heyqbnk
Copy link
Member

heyqbnk commented May 11, 2024

Waiting for @typescript-eslint v9 support: typescript-eslint/typescript-eslint#9002

@heyqbnk
Copy link
Member

heyqbnk commented May 29, 2024

Waiting for @typescript-eslint v9 support: typescript-eslint/typescript-eslint#9002

Alpha version released. Now waiting for jsx-eslint/eslint-plugin-react#3699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants