chore: add knip #8192

auvred · 2024-01-05T16:41:59Z

PR Checklist

Addresses an existing open issue: fixes Repo: Add Knip #8021
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

TODO:

typescript-eslint · 2024-01-05T16:42:02Z

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-01-05T16:42:03Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2188ef8`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66422ee784e82a0008abd70c
😎 Deploy Preview	https://deploy-preview-8192--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg · 2024-04-23T17:06:41Z

jest.config.js

@@ -1,5 +1,9 @@
+'use strict';
+
+// @ts-check


[Praise] Nice, +1 to getting // @ts-check in here.

This reverts commit 36fa481.

JoshuaKGoldberg

✂️ this is fantastic, nice job @auvred! Love the explanations throughout and all the removed stuff.

Nothing I commented is a blocker IMO. They can all be followup issues IMO.

knip.ts

JoshuaKGoldberg · 2024-04-23T17:13:10Z

knip.ts

+ 'packages/repo-tools': {
+ ignoreDependencies: ['tsconfig.json'],
+ },


Yeah this feels like a feature request for Knip: shouldn't it understand that npx tsc goes to TypeScript?

...separately, -p defaults to tsconfig.json. yarn knip and yarn typecheck pass happily for me when I remove the -p tsconfig.json altogether. Maybe a good reason to remove them?

knip.ts

JoshuaKGoldberg · 2024-04-23T17:21:32Z

knip.ts

+ 'src/mock/lru-cache.js',
+ 'src/mock/path.js',
+ 'src/mock/typescript.js',
+ 'src/mock/util.js',


You know, as a followup I bet we could switch these over to plain .ts files, and remove the need for the requireResolved that's tripping up Knip... Not blocking at all IMO.

JoshuaKGoldberg · 2024-04-23T17:22:50Z

packages/utils/src/eslint-utils/index.ts

@@ -1,4 +1,5 @@
 export * from './applyDefault';
+export * from './context';


Probably yeah. The fact that nobody has reported anything makes me less motivated to - but, yeah, we should.

Co-authored-by: Josh Goldberg ✨ <[email protected]>

packages/repo-tools/package.json

@@ -13,16 +13,21 @@
 "lint": "npx nx lint",
 "postinstall-script": "npx tsx ./src/postinstall.mts",
 "test": "npx jest --coverage",
- "typecheck": "npx tsc -p tsconfig.json --noEmit"
+ "typecheck": "npx tsc --noEmit"


JoshuaKGoldberg

🚀

webpro · 2024-04-29T06:38:10Z

Hey folks, this is great! I didn't check out the details of this PR, but feel free to drag me into this, love to help out a bit here. If there's feature requests or other annoying stuff in/from Knip I'd love to hear about it.

auvred · 2024-04-30T14:10:25Z

~~Integration tests failures are unrelated. See #9029 (comment):~~

~~8127873 / #8640~~

~~This commit changed the context.report from { node, ... } to { loc, ... } Hence the nodeType is no longer visible in the output as the rule is not reporting against the node.~~

~~I think we can finally merge this PR!~~

UPD: this issue has been resolved on main

auvred · 2024-05-12T13:46:11Z

Unfortunately, merging main two weeks ago automatically dismissed an existing approval, so I can't merge this PR (the PR authors can't approve their PR). Could someone please re-review and stamp this PR so we can merge it?

Every Monday, after the automatic release, there are a few merge conflicts due to bumped @typescript-eslint/* versions, and it's a bit tedious to resolve them every Monday 😄

rubiesonthesky · 2024-05-13T13:44:51Z

@auvred Could you try running yarn dedupe in this branch and see if all the tests still pass? I think you may have fixed the problem that all the renovate branches have. But I suspect, that it will only manifest itself after yarn dedupe.

auvred · 2024-05-13T13:51:05Z

yarn.lock

Forwarding #8192 (comment) here:

@rubiesonthesky, I've already ran yarn dedupe in one of the previous commits on this PR, but the ast-spec tests didn't pass with deduped lockfile:

https://github.com/typescript-eslint/typescript-eslint/actions/runs/8804176361/job/24164146899

So, I reverted these changes in 5c56b50

Might be useful info: Joshua ran yarn dedupe in the #9002 (merged in v8 branch) - #9002 (comment)

@auvred Sorry and thank you :) That explains everything.

NP! Thank you for Renovate issue investigation!

Yeah I think once someone takes the time to fix the test errors in #8589, we could probably keep it deduped forever. Which would be great.

JoshuaKGoldberg

💯 looks fantastic, thanks for pressing on this! Very excited to have the cross-file unused code detection.

Marking as 1 approval to give you a chance to merge whenever you want. 😁

auvred added 2 commits January 5, 2024 16:39

chore: add knip

d0896c6

chore: sync lockfile

f3bd554

auvred added 3 commits January 5, 2024 16:42

Merge branch 'main' into chore/add-knip

2d7afbc

chore: bump knip

a9b3dd1

ci: run knip in ci workflow

77d0279

auvred mentioned this pull request Jan 6, 2024

Support working-directory keyword in GitHub Actions workflows webpro-nl/knip#433

Open

auvred and others added 22 commits January 6, 2024 08:28

ci: run knip as part of lint job

f074fd7

refactor: replace testRegex with testMatch

27163a2

refactor: use satisfies in knip config

919867d

chore: fix path to rule-tester fixtures

3f3abce

chore: add dummypkg as knip workspace

2b53d17

chore: get rid of json-schema

6f32a3e

chore: fix knip issues in packages/website

47d2703

chore: merge main

56a6d1f

chore: merge main 2

8b9e441

chore: sync lockfile

b24377d

chore: add missed merge stuff

5a1255a

chore: install @jest/types in the root workspace

64cb8c4

chore: partially fix issues for website-eslint

91c9909

chore: fix knip issues for packages/website-eslint

1348b52

e7a204c

chore: add ncp resolution to the root package.json

5d37ea8

Merge branch 'main' into chore/add-knip

85df506

chore: wip wip wip

eea474d

chore: fix misspelling + handle few knip issues

de23db8

chore: finally (?)

19e22c5

chore: expand ignoreDependencies regular expressions

5025e67

chore: revert unrelated changes

6dad589

JoshuaKGoldberg reviewed Apr 23, 2024

View reviewed changes

Revert "!!!"

814c162

This reverts commit 36fa481.

JoshuaKGoldberg previously approved these changes Apr 23, 2024

View reviewed changes

auvred added 3 commits April 23, 2024 20:27

revert yarn dedupe

5c56b50

sed -i 's| -p tsconfig.json||g'

4d163a2

update todo comment in eslint.config.js

263b528

auvred dismissed JoshuaKGoldberg’s stale review via 263b528 April 23, 2024 17:40

Update knip.ts

7e58b47

Co-authored-by: Josh Goldberg ✨ <[email protected]>

auvred mentioned this pull request Apr 23, 2024

Bug(utils): deprecated helpers for ESLint context are not exported #8975

Closed

4 tasks

auvred added 2 commits April 23, 2024 20:57

oops

c7c1114

Merge branch 'main' into chore/add-knip

c65abae

auvred requested a review from JoshuaKGoldberg April 24, 2024 10:37

rubiesonthesky reviewed Apr 25, 2024

View reviewed changes

JoshuaKGoldberg previously approved these changes Apr 26, 2024

View reviewed changes

chore: merge main

7bea876

auvred dismissed JoshuaKGoldberg’s stale review via 7bea876 April 30, 2024 13:53

auvred and others added 2 commits May 3, 2024 21:10

Merge branch 'main' into chore/add-knip

81a6914

Merge branch 'main' into chore/add-knip

3506094

auvred requested a review from JoshuaKGoldberg May 12, 2024 13:41

auvred commented May 13, 2024

View reviewed changes

rubiesonthesky mentioned this pull request May 13, 2024

Repo: renovate updates stuck? #9062

Closed

JoshuaKGoldberg approved these changes May 13, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval One team member has approved this PR; a second should be enough to merge it label May 13, 2024

Merge branch 'main' into chore/add-knip

2188ef8

auvred merged commit f53fece into typescript-eslint:main May 13, 2024
61 checks passed

github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add knip #8192

chore: add knip #8192

auvred commented Jan 5, 2024 •

edited

typescript-eslint bot commented Jan 5, 2024

netlify bot commented Jan 5, 2024 •

edited

JoshuaKGoldberg Apr 23, 2024

JoshuaKGoldberg left a comment

JoshuaKGoldberg Apr 23, 2024

JoshuaKGoldberg Apr 23, 2024

JoshuaKGoldberg Apr 23, 2024

This comment was marked as resolved.

This comment was marked as resolved.

JoshuaKGoldberg left a comment

webpro commented Apr 29, 2024

auvred commented Apr 30, 2024 •

edited

auvred commented May 12, 2024

rubiesonthesky commented May 13, 2024

auvred May 13, 2024

rubiesonthesky May 13, 2024

auvred May 13, 2024

JoshuaKGoldberg May 13, 2024

JoshuaKGoldberg left a comment

		@@ -1,4 +1,5 @@
		export * from './applyDefault';
		export * from './context';

chore: add knip #8192

chore: add knip #8192

Conversation

auvred commented Jan 5, 2024 • edited

PR Checklist

Overview

typescript-eslint bot commented Jan 5, 2024

netlify bot commented Jan 5, 2024 • edited

✅ Deploy Preview for typescript-eslint ready!

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

webpro commented Apr 29, 2024

auvred commented Apr 30, 2024 • edited

auvred commented May 12, 2024

rubiesonthesky commented May 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

auvred commented Jan 5, 2024 •

edited

netlify bot commented Jan 5, 2024 •

edited

auvred commented Apr 30, 2024 •

edited