Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Node package / binding structure #545

Closed
yyx990803 opened this issue Mar 11, 2024 · 0 comments · Fixed by #550
Closed

Improve Node package / binding structure #545

yyx990803 opened this issue Mar 11, 2024 · 0 comments · Fixed by #550
Assignees
@Brooooooklyn @hyf0
Labels
scope: npm package

Comments

@yyx990803
Copy link
Member

Currently @rolldown/node and @rolldown/node-binding are two separate packages with src in two different locations (packges/node and crates/rolldown_binding).

Now that we have acquired the rolldown npm package, the plan is to merge both into a single npm package.

  • This package will contain both the CLI and directly depends on platform-specific bindings as optional dependencies (including the wasm binding)
  • src for this package will be in packages/rolldown
  • crates/rolldown_binding needs to adjust napi-rs build to target packages/rolldown
  • @rolldown/node and @rolldown/node-binding packages will be deprecated as they are no longer needed
@hyf0 hyf0 self-assigned this Mar 11, 2024
hyf0 added a commit that referenced this issue Mar 11, 2024
@hyf0
Closes #545
b11a93e
@hyf0 hyf0 mentioned this issue Mar 11, 2024
Merged
hyf0 added a commit that referenced this issue Mar 11, 2024
@hyf0
Closes #545
c252660
hyf0 added a commit that referenced this issue Mar 11, 2024
@hyf0
Closes #545
a6f1d39
@hyf0 hyf0 closed this as completed in #550 Mar 11, 2024
hyf0 added a commit that referenced this issue Mar 11, 2024
@hyf0
chore(node): improve node/binding structure (#550)
23b0cc0 
* Closes #545

* fix style

* fix deps

* fix ci

* fix style

* improve commands

* Fix justfile

* Finish all

* Fix `prepublishOnly`

* Fix style
@hyf0 hyf0 mentioned this issue Mar 11, 2024
Closed
@trivikr trivikr mentioned this issue Mar 25, 2024
Closed
@trivikr trivikr mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brooooooklyn Brooooooklyn

@hyf0 hyf0

Labels
scope: npm package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(node): improve node/binding structure rolldown/rolldown
3 participants
@yyx990803 @Brooooooklyn @hyf0