Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @rolldown/node and @rolldown/node-binding on npm #657

Closed
trivikr opened this issue Mar 25, 2024 · 3 comments
Closed

Deprecate @rolldown/node and @rolldown/node-binding on npm #657

trivikr opened this issue Mar 25, 2024 · 3 comments
Assignees

Comments

@trivikr
Copy link
Contributor

trivikr commented Mar 25, 2024

Is your feature request related to a problem? Please describe.

The modules @rolldown/node and @rolldown/node-binding were deprecated when team acquired rolldown on npm #545 (comment)

However, some consumers are still using them #622 (comment)

Describe the solution you'd like

Deprecate @rolldown/node and @rolldown/node-binding on npm so that users are aware of the updated module.

Example:

$ npm deprecate @rolldown/node "The package '@rolldown/node' is deprecated. Please use 'rolldown' instead."

Docs for npm deprecate: https://docs.npmjs.com/cli/v10/commands/npm-deprecate

Describe alternatives you've considered

N/A

@yyx990803
Copy link
Member

Done.

@trivikr
Copy link
Contributor Author

trivikr commented Apr 1, 2024

The package @rolldown/node-binding is not deprecated.

It can be done by running:

$ npm deprecate @rolldown/node-binding "The package '@rolldown/node-binding' is deprecated. Please use 'rolldown' instead."

cc @yyx990803

@trivikr
Copy link
Contributor Author

trivikr commented Apr 1, 2024

The package @rolldown/node-binding is not deprecated.

Created a new issue #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants