Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @rolldown/node-binding on npm #720

Closed
trivikr opened this issue Apr 1, 2024 · 1 comment
Closed

Deprecate @rolldown/node-binding on npm #720

trivikr opened this issue Apr 1, 2024 · 1 comment

Comments

@trivikr
Copy link
Contributor

trivikr commented Apr 1, 2024

Is your feature request related to a problem? Please describe.

The module @rolldown/node-binding were deprecated when team acquired rolldown on npm #545 (comment)

However, it's not deprecated on npm.

Describe the solution you'd like

Deprecate @rolldown/node-binding on npm so that users are aware of the updated module.

Example:

$ npm deprecate @rolldown/node-binding "The package '@rolldown/node-binding' is deprecated. Please use 'rolldown' instead."

Docs for npm deprecate: https://docs.npmjs.com/cli/v10/commands/npm-deprecate

Describe alternatives you've considered

N/A

Additional Context

In previous issue reported in #657, but only @rolldown/node was deprecated.

@hyf0
Copy link
Member

hyf0 commented Apr 1, 2024

Thanks for reporting this. I don't think users would rely on @rolldown/node-binding directly. So it's probably enough for just deprecating @rolldown/node.

@trivikr trivikr closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants