chore(node): improve node/binding structure #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
force-pushed
the
chore_node_improve_the_node/binding_structure
branch
from
1fe69a5
to
ec19430
Compare
hyf0
force-pushed
the
chore_node_improve_the_node/binding_structure
branch
from
f01ecc0
to
aa99b39
Compare
|
Since this is a big folder structure change and the ci run successfully, let's merge it first and fix possible issue on top of it. |
yyx990803
reviewed
Mar 12, 2024
| ] | ||
| }, | ||
| "dependencies": { | ||
| "prettier": "^3.2.5" |
yyx990803
reviewed
Mar 12, 2024
| @@ -0,0 +1,76 @@ | |||
| { | |||
| "name": "rolldown", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
The package previously has versions published up to 0.3.0 and 0.4.x-alpha, we should start at 0.5.0 just to be safe.
|
@hyf0 found some small issues. Pinging in case the inline comments get lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #545.
Closes #432.
Test Plan