Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added port and network expose and removed react-scripts #1234

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: added port and network expose and removed react-scripts #1234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab59ce8
feat: added port and network expose and removed react-scripts
developerTested Mar 3, 2024
31c9d25
Merge branch 'main' into main
tamalCodes Mar 11, 2024
a3b3c53
set EXPOSE NETWORK to true
developerTested Mar 11, 2024
cfab35f
Merge branch 'main' of https://github.com/developerTested/Milan
developerTested Mar 11, 2024
eb655ba
Update .env.example
developerTested Mar 30, 2024
cc66d9e
update docs
developerTested Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# Set the port to run Vite Developemnt Server
PORT=3000

# Use Host Name for Vite
HOST_NAME=localhost

# Expose Vite to Network
developerTested marked this conversation as resolved.
Show resolved Hide resolved
EXPOSE_NETWORK=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why is this false ? Suppose I want to expose it in development mode and test it on other devices. Isn't this feature needed then ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that .env var is self explain. If user want to expose it on Network set it true .
It is set as false because let says if u don't want to expose it on network so user have control over it instead by default exposing it HARD CODED that is aim of that variable so in future user won't have to rr-edit vite.config.js and set it false.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will set it as True and push changes in few minutes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'd say then let's keep it false - please update all the concerned docs so that newbies have no problem setting up and navigating through the same. Also please test every command before the final push, will merge it tomorrow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already set it as true. Okay. I will set it as false now.

please point the docs where it need to mention so i will add it there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add explanation for variables at https://github.com/milancommunity/Milan/blob/main/docs/FrontendSetup.md#setting-up-the-env-file


# Use the Backend Setup guide to setup the backend and then use the following:
VITE_MILANAPI="http://localhost:5000"

Expand Down
2 changes: 1 addition & 1 deletion docs/FrontendSetup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Follow the below steps to setup the Frontend locally. We are using `npm` as the

## Setting up the `.env` file

We use a `.env` file using the `dotenv` package inside the root of the directory. You must create a `.env` file similar to [.env.example](../.env.example) file.
We use a `.env` file inside the root of the directory. You must create a `.env` file similar to [.env.example](../.env.example) file.

<br/>
<br/>
Expand Down