feat: added port and network expose and removed react-scripts #1234
Conversation
github-actions
bot
added
status: todo ⏳
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @developerTested, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
|
That's amazing features - since we now have introduced aliases - should we use it in at least files so that we know it works and can be done like this in the future ? |
| HOST_NAME=localhost | ||
|
|
||
| # Expose Vite to Network | ||
| EXPOSE_NETWORK=false |
There was a problem hiding this comment.
Also, why is this false ? Suppose I want to expose it in development mode and test it on other devices. Isn't this feature needed then ?
There was a problem hiding this comment.
that .env var is self explain. If user want to expose it on Network set it true .
It is set as false because let says if u don't want to expose it on network so user have control over it instead by default exposing it HARD CODED that is aim of that variable so in future user won't have to rr-edit vite.config.js and set it false.
There was a problem hiding this comment.
I will set it as True and push changes in few minutes
There was a problem hiding this comment.
Great, I'd say then let's keep it false - please update all the concerned docs so that newbies have no problem setting up and navigating through the same. Also please test every command before the final push, will merge it tomorrow.
There was a problem hiding this comment.
I already set it as true. Okay. I will set it as false now.
please point the docs where it need to mention so i will add it there
There was a problem hiding this comment.
Can add explanation for variables at https://github.com/milancommunity/Milan/blob/main/docs/FrontendSetup.md#setting-up-the-env-file
tamalCodes
added
status: need changes 🚧
|
This pull request has been deployed to Vercel.
|
Co-authored-by: Tinesh Nehete <[email protected]>
|
New changes have been applied |
This PR will add feature which will allow user to pick custom port, hostname, add featured to remove ../.../.../ like import.
closes #1230
👷🏻 Changes made