Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added port and network expose and removed react-scripts #1234
base: main
Are you sure you want to change the base?
feat: added port and network expose and removed react-scripts #1234
Changes from all commits
ab59ce8
31c9d25
a3b3c53
cfab35f
eb655ba
cc66d9e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why is this false ? Suppose I want to expose it in development mode and test it on other devices. Isn't this feature needed then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that .env var is self explain. If user want to expose it on Network set it true .
It is set as false because let says if u don't want to expose it on network so user have control over it instead by default exposing it HARD CODED that is aim of that variable so in future user won't have to rr-edit vite.config.js and set it false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will set it as True and push changes in few minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'd say then let's keep it false - please update all the concerned docs so that newbies have no problem setting up and navigating through the same. Also please test every command before the final push, will merge it tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already set it as true. Okay. I will set it as false now.
please point the docs where it need to mention so i will add it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add explanation for variables at https://github.com/milancommunity/Milan/blob/main/docs/FrontendSetup.md#setting-up-the-env-file