Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flye module #982

Closed
wants to merge 9 commits into from
Closed

Add flye module #982

wants to merge 9 commits into from

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Oct 29, 2021 •
edited by d4straub
Loading

Closes #830.

d4straub
d4straub reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@d4straub d4straub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Please address the comments below.

modules/flye/main.nf Outdated Show resolved Hide resolved
modules/flye/main.nf Outdated Show resolved Hide resolved
tests/modules/flye/main.nf Outdated Show resolved Hide resolved
d4straub
d4straub reviewed Oct 29, 2021
View reviewed changes
modules/flye/main.nf Outdated Show resolved Hide resolved
mahesh-panchal
mahesh-panchal reviewed Oct 29, 2021
View reviewed changes
modules/flye/main.nf Outdated Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
@mirpedrol mirpedrol added the WIP Work in progress label Nov 12, 2021
@drpatelh drpatelh added the new module Adding a new module label Nov 15, 2021
@mirpedrol mirpedrol mentioned this pull request Dec 13, 2021
Merged
@d4straub
Copy link
Contributor

d4straub commented Jul 4, 2022

I guess this PR can be closed since the other one was merged?

@mirpedrol mirpedrol closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal left review comments

@d4straub d4straub d4straub left review comments

Assignees
No one assigned
Labels
new module Adding a new module WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: flye
5 participants
@mirpedrol @d4straub @mahesh-panchal @drpatelh @Masaga8