Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new module: Flye #1164

Merged
merged 35 commits into from
Jun 30, 2022
Merged

Add new module: Flye #1164

merged 35 commits into from
Jun 30, 2022

Conversation

mirpedrol
Copy link
Member

Closes #830
Updates PR #982 to DSL2

@mirpedrol
changing mv by gzip
00a752a
@mirpedrol
changing mv by gzip
c1cb4fe
@mirpedrol
first module creation
6963945
@mirpedrol
add test.yml
21cf17e
@mirpedrol
Merge branch 'flye' of https://github.com/asthara10/modules into flye
146d99e
@mirpedrol
update changes
c573575
@mirpedrol
add flye to pyestes_modules.yml
1318541
@mirpedrol
update flye module
8e3fb3c
@mirpedrol
delete functions.nf
ff31209
@mirpedrol
generate test.yml
fc7921e
@mirpedrol
Apply changes made in gitpod
1a0fb3d 
Merge branch 'flye' of https://github.com/mirpedrol/modules into flye
@mirpedrol
fix contains from test.yml
9109d46
@mirpedrol
test file assembly_info.txt with regex
08e2252
@mirpedrol
check that file contains at least contig_1
ddcd84d
@mirpedrol
fix typo in contains
b1527cd
@mirpedrol
Merge branch 'master' into flye
6ae2a69
@mirpedrol
update version
4772601
@mirpedrol
split fastq file for raw runs
a5a1b15
@mirpedrol
use asm-coverage to reduce memory usage
5064fab
@mirpedrol
fix module name error
2da96e8
@mirpedrol
add genome-size
93bd62c
@mirpedrol
decrease coverage
ed20095
@mirpedrol
change test data for raw runs
0918e49
@mirpedrol
add coverage and genome size
2821de2
SusiJo
SusiJo reviewed Jun 29, 2022
View reviewed changes
modules/flye/main.nf Outdated Show resolved Hide resolved
jfy133
jfy133 requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly cosmetic changes, but missing description in meta.yml of tje mode input

modules/flye/main.nf Outdated Show resolved Hide resolved
modules/flye/main.nf Outdated Show resolved Hide resolved
modules/flye/main.nf Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
modules/flye/meta.yml Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
modules/flye/meta.yml Outdated Show resolved Hide resolved
modules/flye/main.nf Show resolved Hide resolved
@mirpedrol @jfy133
Apply suggestions from code review
4d656a6 
Co-authored-by: James A. Fellows Yates <[email protected]>
SusiJo
SusiJo reviewed Jun 30, 2022
View reviewed changes
modules/flye/main.nf Outdated Show resolved Hide resolved
SusiJo
SusiJo reviewed Jun 30, 2022
View reviewed changes
modules/flye/main.nf Outdated Show resolved Hide resolved
@mirpedrol @mahesh-panchal
Update modules/flye/main.nf
0c913e2 
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
@mirpedrol mirpedrol merged commit bd0fa88 into nf-core:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal left review comments

@SusiJo SusiJo SusiJo left review comments

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: flye
4 participants
@mirpedrol @mahesh-panchal @jfy133 @SusiJo