Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unity plugin] Fix the missing .meta for copied library. #1154

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Unity plugin] Fix the missing .meta for copied library. #1154

wants to merge 5 commits into from

Conversation

ganyuanzhen
Copy link

Fix #1146

@ganyuanzhen ganyuanzhen marked this pull request as draft November 1, 2023 06:42
@ganyuanzhen ganyuanzhen marked this pull request as ready for review November 1, 2023 07:00
@ganyuanzhen ganyuanzhen changed the title Fix the missing .meta for copied library. [Unity plugin] Fix the missing .meta for copied library. Nov 2, 2023
@yuvaltassa
Copy link
Collaborator

@Balint-H LGTY?

Balint-H
Balint-H reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Balint-H Balint-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it works as intended, even as a URL referenced packages. I have some very minor suggestions regarding the message printed out after the library is imported, but otherwise its a good fix.

unity/Editor/Bindings/MujocoBinaryRetriever.cs Outdated Show resolved Hide resolved
unity/Editor/Bindings/MujocoBinaryRetriever.cs Outdated Show resolved Hide resolved
@ganyuanzhen
Update MujocoBinaryRetriever.cs
5b765b8 
Update console output.
@ganyuanzhen
Copy link
Author

Already add some minor changes to the prompts and change the vaiable name to filePath. @Balint-H

@erez-tom
Copy link
Collaborator

Thanks for this!
Two alternatives to consider:

  1. Call Refresh after copy.
  2. Use Unity's FileUtil instead of System.
    If you have reasons to reject both, we can accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balint-H Balint-H Balint-H left review comments

@yuvaltassa yuvaltassa yuvaltassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing a .meta file for the mujoco.dll in the unity plugin
4 participants
@ganyuanzhen @yuvaltassa @erez-tom @Balint-H