hide non-polymorphic sites feature added to the filter menu #188
Conversation
| @@ -25,6 +25,22 @@ const FilterMenu = MenuBuilder.extend({ | |||
| return this.g.columns.set("hidden", hidden); | |||
| }); | |||
|
|
|||
| this.addNode("Hide non-polymorphic sites",(e) => { | |||
| var threshold = prompt("Enter identity threshold (in percent)", 100); | |||
| threshold = threshold / 100; | |||
There was a problem hiding this comment.
it's very common to either check, or clamp user input. It could be as easy as this:
import {clamp} from "lodash"; // header
...
threshold = clamp(threshold / 100, 0, 1);
Thanks. Looks all good to me 👍 I had some minor comments about the style though, do you mind addressing them? |
|
Thanks for the comments for code improvement =) I reused your code from one of the filter options to create this new one but I will change the code and pull it here. |
Yep as said, some parts are still "dirty" as they were converted from CoffeeScript. Did you manage to adapt the changes? (I can't see them here). |
|
ping @bfrgoncalves ;-) |
Option to hide non-polymorphic sites. It hides the columns which nucleotide identity at a given position is above the threshold.
Bruno Gonçalves