Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run pre commit in ci for code quality #225

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ci: run pre commit in ci for code quality #225

wants to merge 8 commits into from

Commits on Sep 13, 2023

  1. ci: run pre commit in ci for code quality

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5755af1 View commit details
    Browse the repository at this point in the history

  2. ci: black formatting after running pre-commit --all-files

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6f5da00 View commit details
    Browse the repository at this point in the history

  3. chore: pre-commit in combination with skip does not work, for ci we n… 

    …eed ignore-words
    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0229b4e View commit details
    Browse the repository at this point in the history

  4. ci: isort formatting after running pre-commit --all-files

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f29f427 View commit details
    Browse the repository at this point in the history

  5. ci: make mypy happy about package/assets/hatch_build.py

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    88a47d4 View commit details
    Browse the repository at this point in the history

  6. ci: install solara so isort does not re-order

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    91b6691 View commit details
    Browse the repository at this point in the history

  7. ci: isort does not always recognize solara as first party

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f792985 View commit details
    Browse the repository at this point in the history

  8. chore: try modern isort

    @maartenbreddels
    maartenbreddels committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a19f2ca View commit details
    Browse the repository at this point in the history