ci: run pre commit in ci for code quality #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of manually keeping pre-commit versions in sync with CI, lets also use pre-commit in CI |
maartenbreddels
force-pushed
the
ci_use_pre_commit
branch
2 times, most recently
from
82b19e2
to
8aa58c7
Compare
|
Giving up for now, I have no idea why isort under Python 3.9 decides to reorder imports. |
|
After d15ec01 it seems that we cannot install isort on Python 3.7 anymore. Might be a clue that the isort on 3.9 in pre commit does not respect the version number in the pre commit file. |
maartenbreddels
force-pushed
the
ci_use_pre_commit
branch
from
d15ec01
to
a19f2ca
Compare
maartenbreddels
force-pushed
the
master
branch
4 times, most recently
from
2446983
to
0d6161d
Compare
iisakkirotko
force-pushed
the
master
branch
2 times, most recently
from
c2951b9
to
8816e36
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
240a079
to
b098da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.