Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rescoreLimit to HNSW BQ & PQ #4724

Open
wants to merge 5 commits into
base: stable/v1.24
Choose a base branch
from
Open

Add rescoreLimit to HNSW BQ & PQ #4724

wants to merge 5 commits into from

Conversation

abdelr
Copy link
Contributor

@abdelr abdelr commented Apr 19, 2024

What's being changed:

Separating rescore limit from ef for better performance in large search lists.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@abdelr abdelr mentioned this pull request Apr 19, 2024
Closed
4 tasks
@abdelr
Copy link
Contributor Author

abdelr commented Apr 19, 2024 •
edited

output
Some performance gain seen with BQ. Notice the end of the curve, where we aim for higher recall. There the performance difference is more evident.

@abdelr abdelr self-assigned this Apr 19, 2024
@abdelr
fixing acceptance test
a3b33ff 
missing from last commit
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
36.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@trengrj trengrj mentioned this pull request Apr 24, 2024
Merged
@trengrj trengrj changed the title Cleaned rescore limit Add rescoreLimit to HNSW BQ & PQ Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trengrj trengrj trengrj approved these changes

@asdine asdine Awaiting requested review from asdine

@etiennedi etiennedi Awaiting requested review from etiennedi

@CShorten CShorten Awaiting requested review from CShorten

Assignees

@abdelr abdelr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abdelr @trengrj