Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rescore limit #4633

Closed
wants to merge 3 commits into from
Closed

adding rescore limit #4633

wants to merge 3 commits into from

Conversation

abdelr
Copy link
Contributor

@abdelr abdelr commented Apr 9, 2024

What's being changed:

Separating rescore limit from ef for better performance in large search lists.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@abdelr abdelr self-assigned this Apr 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
44.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@abdelr
Copy link
Contributor Author

abdelr commented Apr 19, 2024

Closed in favour of #4724

@abdelr abdelr closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdine asdine Awaiting requested review from asdine

@trengrj trengrj Awaiting requested review from trengrj

@CShorten CShorten Awaiting requested review from CShorten

Assignees

@abdelr abdelr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abdelr