Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support assertionExceptions without priority prefix #1053

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support assertionExceptions without priority prefix #1053

wants to merge 3 commits into from

Conversation

evmiguel
Copy link
Contributor

@evmiguel evmiguel commented Apr 24, 2024 •
edited by github-actions bot

Preview Tests

This PR addresses #1046, providing support for test plans with assertionExceptions that do not have a priority prefix.

The following changes were added:

  • Relaxed regex check on assertionExceptions
  • Util file for setting default assertion priorities

@evmiguel evmiguel requested a review from howard-e April 24, 2024 14:52
howard-e
howard-e approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evmiguel looks good! Well done, in also considering a lot of these files are new to you.

How this is done also makes it so that there shouldn't be any additional changes to how the harness files or the aria-at-app handle these assertionExceptions which is great!

lib/data/parse-test-csv-row.js Outdated
@@ -216,12 +218,16 @@ function parseTestCSVRowV2({ tests, assertions, scripts, commands }) {
at => at.key === key && at.settings === (command.settings || 'defaultMode')
)
) {
const assertionExceptions = setDefaultAssertionExceptionsFromTest(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setDefaultAssertionPriority seems like a more appropriate name here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@howard-e addressed this in 1373d76

howard-e
howard-e approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing that last bit of feedback and addressing the issue with the false error being thrown. Great stuff!

@howard-e howard-e requested a review from mcking65 April 24, 2024 20:09
@howard-e
Copy link
Contributor

@mcking65 this PR should now address #1046. So making it possible that instances of valid assertionIds can be listed in *-commands.csv > assertionExceptions without needing a priority prefix. But would instead default to the priority already noted for that assertionId from assertions.csv if applicable.

Could you confirm this works as expected?

@ccanash ccanash mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evmiguel @howard-e