Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support test plans that specify a command assertion exception that does not include an assertion priority prefix #1046

Open
mcking65 opened this issue Mar 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mcking65
Copy link
Contributor

This is a test writing simplification proposal that is related to #1045. It might be a good idea to implement both #1045 and this request in a single PR.

Currently, assertion exceptions in the *-commands.csv files are required to have a priority prefix of n: where n is 0, 1, 2, or 3. This proposal is to support omitting the priority prefix in the assertionExceptions column of *-commands.csv in situations where the test author wants the priority specified in tests.csv or assertions.csv to be assigned to the assertion.

For example, the priority of assertions for switching screen reader mode is specified in assertions.csv. It is typically 2. It is redundant to require the test author to specify it again in the commands file. Requiring the author to repeat the priority in the commands file creates opportunity for accidental inconsistency across AT or even among different commands for a specific AT.

The current priority precedence defined in the V2 format would not change. That is:

  1. The priority specified in commands.csv is assigned if specified.
  2. If priority is not specified in commands.csv, the priority specified in tests.csv is assigned.
  3. If priority is not specified in tests.csv, the priority specified in assertions.csv is assigned.
@ccanash
Copy link

ccanash commented May 1, 2024

Hi @mcking65 can you please confirm this works as expected? Please see comment in #1053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants