Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Middleware Appliers for Third Party Middlewares #5294

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

Nick-Lucas
Copy link
Contributor

Updated RFC to point at Next

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

βœ… Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@Nick-Lucas Nick-Lucas changed the base branch from main to next January 9, 2024 19:32
Copy link

github-actions bot commented Jan 9, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 735 735 (βž– 0)
Lines of Library 40,241 40,241 (βž– 0)
Lines of Definitions 118,641 118,636 (πŸ”Ί 5)
Lines of TypeScript 4,867 4,867 (βž– 0)
Lines of JavaScript 0 0 (βž– 0)
Lines of JSON 0 0 (βž– 0)
Lines of Other 0 0 (βž– 0)
Identifiers 174,791 174,786 (πŸ”Ί 5)
Symbols 108,829 108,826 (πŸ”Ί 3)
Types 89 89 (βž– 0)
Instantiations 0 0 (βž– 0)
Memory used 174,441 167,864 (πŸ”Ί 6,577)
Assignability cache size 0 0 (βž– 0)
Identity cache size 0 0 (βž– 0)
Subtype cache size 0 0 (βž– 0)
Strict subtype cache size 0 0 (βž– 0)

Timings and averages

Metric PR next
max (s) 4.752 4.918 (πŸ”½πŸŸ’ -0.17)
min (s) 4.752 4.918 (πŸ”½πŸŸ’ -0.17)
avg (s) 4.752 4.918 (πŸ”½πŸŸ’ -0.17)
median (s) 4.752 4.918 (πŸ”½πŸŸ’ -0.17)
length 1 1 (βž– 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.04 0.04 (βž– 0)
Parse time 0.73 0.76 (πŸ”½πŸŸ’ -0.03)
ResolveTypeReference time 0.03 0.04 (πŸ”½πŸŸ’ -0.01)
ResolveModule time 0.12 0.11 (πŸ”Ί 0.01)
ResolveLibrary time 0.02 0.03 (πŸ”½πŸŸ’ -0.01)
Program time 1.07 1.09 (πŸ”½πŸŸ’ -0.02)
Bind time 0.44 0.45 (πŸ”½πŸŸ’ -0.01)
Total time 1.51 1.54 (πŸ”½πŸŸ’ -0.03)

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
next-prisma-starter βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 12, 2024 3:35pm
og-image βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 12, 2024 3:35pm
trpc-next-app-dir ❌ Failed (Inspect) Jan 12, 2024 3:35pm
www ❌ Failed (Inspect) Jan 12, 2024 3:35pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant