Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Middleware Appliers for Third Party Middlewares #5112

Closed
wants to merge 1 commit into from

Conversation

Nick-Lucas
Copy link
Contributor

@Nick-Lucas Nick-Lucas commented Nov 27, 2023

A problem we continue to have with the experimental standalone middlewares, and also t.middleware, is that they have caused many bugs with type inference over time, and so compose unreliably. It's not clear that all problems are solvable.

This is an approach which draws inspiration from other libraries like Tanstack Router, and simply doesn't try to fight the typescript type system by making everything into a function call of known type

I copied over the minimal example project for this prototype so the diff looks bigger than it should, focus on:

🎯 Changes

What changes are made in this PR? Is it a feature or a bug fix?

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@Nick-Lucas
Copy link
Contributor Author

Closed in favour of #5294

Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant