Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings): update npm scripts #3210

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ObserverOfTime
Copy link
Member

@ObserverOfTime ObserverOfTime commented Mar 24, 2024

  • npm run build is removed

  • npm run parse is removed

  • npm run prebuildify is removed

    • use npm x -- prebuildify ... instead
  • npm start will run ts playground (after ts build --wasm)

    • the build can be skipped with npm start --ignore-scripts
  • npm test will run node --test instead of ts t

    tree-sitter commands can be run with npm x -- tree-sitter ...

@clason
Copy link
Contributor

clason commented Mar 27, 2024

I would prefer to keep the management commands local to npm (or ideally tree-sitter) and leave the Makefile as a simple build harness (the sole usecase in my view is to be able to easily compile the parser from a release tarball without having tree-sitter CLI installed).

@ObserverOfTime
Copy link
Member Author

ObserverOfTime commented Mar 27, 2024

I would prefer to keep the management commands local to npm (or ideally tree-sitter) and leave the Makefile as a simple build harness

Well, make test is still valuable (since some parsers may also want to run ts parse alongside ts test) but make update might indeed be unnecessary. Though perhaps make test should run C binding tests instead. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants