Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prebuildify version to fix breaking change on windows #3374

Closed
wants to merge 1 commit into from

Conversation

ahelwer
Copy link
Contributor

@ahelwer ahelwer commented May 19, 2024

This recent node.js security fix causes prebuildify 6.0.0 to fail when running on windows. It will have the following error message:

Run npm x -- prebuildify --strip --arch x64
node:internal/child_process:414
    throw errnoException(err, 'spawn');
    ^

Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:414:11)
    at Object.spawn (node:child_process:761:9)
    at D:\a\tree-sitter-tlaplus\tree-sitter-tlaplus\node_modules\prebuildify\index.js:230:22
    at D:\a\tree-sitter-tlaplus\tree-sitter-tlaplus\node_modules\mkdirp-classic\index.js:30:20
    at FSReqCallback.oncomplete (node:fs:192:23) {
  errno: -4071,
  code: 'EINVAL',
  syscall: 'spawn'
}

Node.js v18.20.2

@ObserverOfTime
Copy link
Member

Already doing it in #3210. Grammars can just npm update until that's merged.

@ahelwer ahelwer closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants