LED Panel! #181
LED Panel! #181
Conversation
| class LEDPanel: | ||
| # Key: Match number, Value: Drop Bears match number (<=15) | ||
| # TODO: Fill with proper values when the draw comes out | ||
| matches: dict[int, int] = {1: 1} |
There was a problem hiding this comment.
The match schedule has been published. Do you intend to fill this in now?
| self.send_packet() | ||
|
|
||
| def execute(self) -> None: | ||
| self.set_match_state() |
There was a problem hiding this comment.
This seems to send a packet multiple times each control loop iteration. Is this necessary?
| self.panel_port = wpilib.SerialPort( | ||
| baudRate=9600, port=wpilib.SerialPort.Port.kUSB1, dataBits=8 | ||
| ) | ||
| self.set_match_id() |
There was a problem hiding this comment.
This happens on robot code start. getMatchNumber will always be invalid in this scenario, as the Driver Station will not have connected to the robot.
| match_id = 0 | ||
| if ( | ||
| match_type == wpilib.DriverStation.MatchType.kQualification | ||
| or match_type == wpilib.DriverStation.MatchType.kElimination |
There was a problem hiding this comment.
Will both this robot code and the LED panel code be updated after every playoff match? Sounds tedious.
| or match_type == wpilib.DriverStation.MatchType.kElimination | ||
| ): | ||
| match_number = wpilib.DriverStation.getMatchNumber() | ||
| if match_number in self.matches: |
There was a problem hiding this comment.
This looks up the match number without using the match type. Is QF4 intended to be considered identical to Q4?
| elif wpilib.DriverStation.getMatchTime() <= 0: | ||
| # Post match |
There was a problem hiding this comment.
Wouldn't this branch be hit before a match, and between auto and teleop, too?
No description provided.