Add graphics in terminal support: - Sixel and iTerm2 protocols #2973

MatanZ · 2022-09-04T18:13:49Z

This commit implements graphics in the terminal, including two different protocols for placing images:

Sixel, and
iTerm2

I ran this for a few days, and it seems to me that some people tried it from #142, and saw no crashes, so I hope it is reasonable safe.

In TerminalEmulator, interpret sixel sequences, and send them to
TerminalBuffer for constructing a bitmap.
Sixel sequences may be longer than 8192 characters, so break them in
natural places ($,-,#), rather than collecting all in the buffer.
The bitmap is sliced to character cell sized slices, and each the
the style attribute is used to store which bitmap slice is displayed
in place of this character.
In TerminalRenderer the style is interpreted, and drawn using
drawBitmap, instead of drawText.

Support iTerm2 inline image protocol (OSC 1337):

Using the same bitmap display infrastructure introduced for sixels.
Collects the image data outside of the OSC buffer.
Ignoring some parameters.

Small emulator changes:

Also eat APC sequences, not echoing to screen.
Fix CSI 14 t to give actual size
Add CSI 16 t
Add 4 (sixel) to device attributes

For those who tried this branch already, I force pushed to it in order to remove changes that may not be acceptable.

The main known issue is that if graphics sequence is interrupted (in specific places), the emulator remains stuck waiting for the sequence to end, thus ignoring all input. This requires terminal reset from the menu.

- In TerminalEmulator, interpret sixel sequences, and send them to TerminalBuffer for constructing a bitmap. - Sixel sequences may be longer than 8192 characters, so break them in natural places ($,-,#), rather than collecting all in the buffer. - The bitmap is sliced to character cell sized slices, and each the the style attribute is used to store which bitmap slice is displayed in place of this character. - In TerminalRenderer the style is interpreted, and drawn using drawBitmap, instead of drawText. Support iTerm inline image protocol (OSC 1337): - Using the same bitmap display infrastructure introduced for sixels. - Collects the image data outside of the OSC buffer. - Ignoring some parameters. Small emulator changes: - Also eat APC sequences, not echoing to screen. - Fix `CSI 14 t` to give actual size - Add `CSI 16 t` - Add `4` (sixel) to device attributes

Add missing {} that change the logic.

aicynide · 2022-09-05T21:36:21Z

You are a hero my brother

KitsunedFox · 2022-09-05T22:50:15Z

It works! but gifs are being duplicated on the terminal when expanding and collapsing the keyboard

Regular images are being displayed fine

MatanZ · 2022-09-06T09:48:27Z

It works! but gifs are being duplicated on the terminal when expanding and collapsing the keyboard

This is not a bug. img2sixel displays animations by sending each frame as a different sixel with a command to send the cursor to position (1,1) between them (CSI H). This causes each frame to overwrite the previous one.

When you remove the keyboard, the screen gets taller, and termux handles this by scrolling down, so the previous frame which was at position (1,1), is now lower, so it is not covered by the following frames.

KitsunedFox · 2022-09-06T10:48:31Z

oh, so everything's working fine then

KitsunedFox · 2022-09-06T11:14:47Z

Here's a small guide for anyone else who wants to test this PR

For displaying images and gifs using Sixel, do pkg install libsixel and use img2sixel image.png

For displaying images using iTerm2, download the imgcat script, and use it with the command ./imgcat image.png

sylirre · 2022-09-06T16:16:54Z

Has issues with big images. For example when using imgcat without limiting width Termux app may get crashed due to out-of-memory exception:

09-06 19:10:37.740 10702 10702 E Termux  : java.lang.OutOfMemoryError: Failed to allocate a 521628640 byte allocation with 74375880 free bytes and 232MB until OOM, target footprint 99167840, growth limit 268435456
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalBuffer.resizeBitmap(TerminalBuffer.java:48)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalBuffer.addImage(TerminalBuffer.java:199)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.doOscSetTextParameters(TerminalEmulator.java:2304)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.doOsc(TerminalEmulator.java:2043)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.processCodePoint(TerminalEmulator.java:577)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.processByte(TerminalEmulator.java:553)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.append(TerminalEmulator.java:502)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalSession$MainThreadHandler.handleMessage(TerminalSession.java:345)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Handler.dispatchMessage(Handler.java:106)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Looper.loopOnce(Looper.java:201)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Looper.loop(Looper.java:288)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.app.ActivityThread.main(ActivityThread.java:7898)
09-06 19:10:37.740 10702 10702 E Termux  :      at java.lang.reflect.Method.invoke(Native Method)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Test image (7779x4191): https://user-images.githubusercontent.com/107305601/188685258-87eb0704-12c5-4b43-a47a-a1deae99e208.jpg

Device config: Pixel 5, Android 13, 8 GiB RAM.

KitsunedFox · 2022-09-06T16:43:04Z

Has issues with big images. For example when using imgcat without limiting width Termux app may get crashed due to out-of-memory exception:

09-06 19:10:37.740 10702 10702 E Termux  : java.lang.OutOfMemoryError: Failed to allocate a 521628640 byte allocation with 74375880 free bytes and 232MB until OOM, target footprint 99167840, growth limit 268435456
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalBuffer.resizeBitmap(TerminalBuffer.java:48)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalBuffer.addImage(TerminalBuffer.java:199)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.doOscSetTextParameters(TerminalEmulator.java:2304)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.doOsc(TerminalEmulator.java:2043)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.processCodePoint(TerminalEmulator.java:577)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.processByte(TerminalEmulator.java:553)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalEmulator.append(TerminalEmulator.java:502)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.termux.terminal.TerminalSession$MainThreadHandler.handleMessage(TerminalSession.java:345)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Handler.dispatchMessage(Handler.java:106)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Looper.loopOnce(Looper.java:201)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.os.Looper.loop(Looper.java:288)
09-06 19:10:37.740 10702 10702 E Termux  :      at android.app.ActivityThread.main(ActivityThread.java:7898)
09-06 19:10:37.740 10702 10702 E Termux  :      at java.lang.reflect.Method.invoke(Native Method)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
09-06 19:10:37.740 10702 10702 E Termux  :      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Test image (7779x4191): https://user-images.githubusercontent.com/107305601/188685258-87eb0704-12c5-4b43-a47a-a1deae99e208.jpg

Device config: Pixel 5, Android 13, 8 GiB RAM.

Image displays fine on termux-monet with android:largeHeap="true" flag. Try adding this flag to your AndroidManifest.xml, it should fix oom exception. largeHeap flag does let applications to use more RAM.
And also, don't forget to disable PhantomProcessKiller, since you're on Android 13.

Device Config: Xiaomi POCO F1, Android 12L, 6GB RAM

cogburnd02 · 2022-09-06T17:13:24Z

I believe if MatanZ gets this imported and issue 142 gets solved, then MatanZ gets my $100 bounty on Bountysource for that issue. It will be well worth it!! :-D

sylirre · 2022-09-06T17:22:24Z

Thanks, but anyway there is some proper workaround needed to avoid OOM. Larger heap indeed can solve it for a particular case. Not all devices have lots of memory and part is always used by other apps including system, max heap size also vary between device models.

Unfortunately I can't propose the best way to implement that, but I think refusing to display supersized bitmaps is better than crashing all sessions. For example if dimensions are too big, user can get a toast message describing the issue.

Command line programs should not be able to crash terminal or cause resource overload by just sending some control sequence (no matter whether it is sixel or something else).

- For iterm2 images - catch the error, and cancel the image. - For sixels - if it happens when resizing the bitmap, than ignore drawing outside of the current image.

KitsunedFox · 2022-09-06T18:22:46Z

Thanks, but anyway there is some proper workaround needed to avoid OOM. Larger heap indeed can solve it for a particular case. Not all devices have lots of memory and part is always used by other apps including system, max heap size also vary between device models.

Unfortunately I can't propose the best way to implement that, but I think refusing to display supersized bitmaps is better than crashing all sessions. For example if dimensions are too big, user can get a toast message describing the issue.

Command line programs should not be able to crash terminal or cause resource overload by just sending some control sequence (no matter whether it is sixel or something else).

I don't believe that making the terminal refuse to display oversized images is necessary, since most of command line programs always will be able to crash the application when overloaded or abused.

That would only limit how the user should use his terminal, creating a "fake error" that doesn't even exist for some users, like the people who has enough RAM for displaying those images.

Those people who can display the images wouldn't be able to.

But if you guys decide that's the best thing to do, i propose placing a limit only for devices with less than 4GB RAM.

MatanZ · 2022-09-06T18:37:13Z

Here's a small guide for anyone else who wants to test this PR

For displaying images and gifs using Sixel, do pkg install libsixel and use img2sixel image.png

For displaying images using iTerm2, download the imgcat script, and use it with the command ./imgcat image.png

Just so I can get more testing from the nice people who test my code:

There are other sixel encoders, for example ImageMagick. Simple example: convert image.jpg sixel:-
gnuplot can also output sixel, but I am not sure if it uses its own encoder, or one of the above. Use set terminal sixelgd.
imgcat has some parameters to control scaling of the image, but you don't even need it. iterm2 protocol is as simple as: echo -en '\e]1337;File=inline=1;keepAspectRatio=0;height=70%:' ; base64 -w 0 /sdcard/z1.jpg ; echo -e '\e\\' . You can have width parameter in addition to height.

KitsunedFox · 2022-09-06T18:52:51Z

Tested with imagemagick, and it's displaying fine on my side

MatanZ · 2022-09-06T19:11:10Z

Thanks, but anyway there is some proper workaround needed to avoid OOM. Larger heap indeed can solve it for a particular case. Not all devices have lots of memory and part is always used by other apps including system, max heap size also vary between device models.

Unfortunately I can't propose the best way to implement that, but I think refusing to display supersized bitmaps is better than crashing all sessions. For example if dimensions are too big, user can get a toast message describing the issue.

Command line programs should not be able to crash terminal or cause resource overload by just sending some control sequence (no matter whether it is sixel or something else).

I hope this solves the problem. I put a try{}catch() block around each bitmap operation that allocates memory. This should be similar to what you suggest - ignoring large images, without hard coding a definition of large.

I believe it is better without a toast notification. Usually when a terminal cannot (or does not want to) perform a certain operation it just ignores it, without notifying the user. Maybe a line in the log.

agnostic-apollo · 2022-09-06T21:37:41Z

@MatanZ Please use dedicated class for long sixel logic in TerminalEmulator and TerminalBuffer.

Trying to catch OutOfMemoryError and freeing resources "should" work. For normal images, one can display bitmap at lowed res, not sure if something like that can be done with sixel, instead of showing nothing at all.

Checking current memory before even trying to display large image could be done too.

https://developer.android.com/reference/android/app/ActivityManager#getMemoryInfo(android.app.ActivityManager.MemoryInfo)

https://developer.android.com/topic/performance/graphics/load-bitmap#read-bitmap

Maybe a line in the log.

This is the way. No toasts. Being done in other places too.

MatanZ · 2022-09-07T10:25:34Z

@MatanZ brother kitty image protocol when?

The way graphics display is implemented, it is not possible to implement kitty protocol. It is possible to implement very simplified ("put image here"), but image and placement management, as well as combining text and images is impossible.

- Move working bitmap code (drawing current bitmap) to WorkingTerminalBitmap class. - Move bitmap handling code to TerminalBitmap class.

MatanZ · 2022-09-07T13:31:09Z

@MatanZ Please use dedicated class for long sixel logic in TerminalEmulator and TerminalBuffer.

Refactored some code to two new classes. I don't see anything in TerminalEmulator that belongs in another class, or which may become clearer.

Trying to catch OutOfMemoryError and freeing resources "should" work. For normal images, one can display bitmap at lowed res, not sure if something like that can be done with sixel, instead of showing nothing at all.

Checking current memory before even trying to display large image could be done too.

https://developer.android.com/reference/android/app/ActivityManager#getMemoryInfo(android.app.ActivityManager.MemoryInfo)
https://developer.android.com/topic/performance/graphics/load-bitmap#read-bitmap

I am not sure this is a good idea. I would have to add assumptions about how much memory is used by the android for various bimap manipulations (decode, scale, resize). I'll settle for trying anything the user asks for, and catching the errors. I did not crash termux with this, with all the above, and various other large images.

agnostic-apollo · 2022-09-07T17:28:31Z

Thanks. Will take another look later myself during merging.

You can also let OutOfMemoryError happen and then try to display lower res once and see if OutOfMemoryError triggers or not and abort if it did. This way would increase chances for user to get to see something than nothing at all. Of course that would add code, so just a suggestion.

sylirre · 2022-09-07T22:04:34Z

Seems like there is a problem with some GIFs. Notice the artifacts at the left part. Same as #142 (comment)?

Gif file doesn't seem to be corrupted.

screen-20220908-005128.2.mp4

This doesn't happen with another gif:

screen-20220908-005944.2.mp4

MatanZ · 2022-09-08T08:16:17Z

I cannot see those videos. And can you please include the actual files used, and the commands that cause the problem?

To avoid removing elements from the map while iterating over it. This should solve the Concurrent Modification Exception in the bitmap garbage collection.

sylirre · 2022-09-08T09:10:32Z

Perhaps the issue with Termux img2sixel utility, not with application.

I can reproduce it when connected over SSH to Termux from Konsole on laptop. But I can't reproduce the issue when animation is played via img2sixel directly in Konsole.

Screenshot with the problem (notice the block with lines on the left side):

You can get the file from https://upload.wikimedia.org/wikipedia/commons/thumb/2/2c/Rotating_earth_%28large%29.gif/274px-Rotating_earth_%28large%29.gif

libsixel package version differences:

Termux

img2sixel 1.10.3

configured with:
  libcurl: no
  libpng: no
  libjpeg: no
  gdk-pixbuf2: no
  GD: no

Laptop (OpenSUSE Tumbleweed)

img2sixel 1.10.3

configured with:
  libcurl: yes
  libpng: no
  libjpeg: yes
  gdk-pixbuf2: yes
  GD: yes

The difference in a build time configuration. Though maybe OpenSUSE also applies some patches to the package.

Fixes issue with some GIFs. See my comment at termux/termux-app#2973 (comment) Also enable libcurl support.

sylirre · 2022-09-08T09:34:02Z

Commit termux/termux-packages@b72be3c resolves img2sixel issue with animation.

Fixes issue with some GIFs. See my comment at termux/termux-app#2973 (comment) Also enable libcurl support.

MatanZ · 2022-09-18T13:52:03Z

Is this supposed to happen or is it a bug?

It is a bug. should be fixed now.

Anonymous2716 · 2022-09-20T14:44:36Z

I get outofmemory crash error just for keept open a few text editor and if try to change the orientation of display , or change size.

KitsunedFox · 2022-09-20T14:54:15Z

@Anonymous2716 what's your device specifications and OS version?
Also could you please provide a crash report?

Anonymous2716 · 2022-09-20T21:43:42Z

@HardcodedCat

Crash Details

Crash Thread: Thread[main,5,main]
Crash Timestamp: 2022-09-20 19:34:09.390 UTC

Crash Message:

OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available

Stacktrace

java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available

Termux App Info

APP_NAME: Termux
PACKAGE_NAME: com.termux
VERSION_NAME: 0.118.0
VERSION_CODE: 118
TARGET_SDK: 28
IS_DEBUGGABLE_BUILD: false
APK_RELEASE: F-Droid
SIGNING_CERTIFICATE_SHA256_DIGEST: 228FB2CFE90831C1499EC3CCAF61E96E8E1CE70766B9474672CE427334D41C42

Device Info

Software

OS_VERSION: 4.4.146
SDK_INT: 28
RELEASE: 9

IS_DEBUGGABLE: 0
IS_TREBLE_ENABLED: true
TYPE: user
TAGS: release-keys

Hardware

BOARD: MK008
HARDWARE: mt6757

SUPPORTED_ABIS: arm64-v8a, armeabi-v7a, armeabi

4GB of RAM

Grimler91 · 2022-10-30T14:38:01Z

dmagnetic is another program(/game) we have that support sixels out of the box. To test, install dmagnetic, download a game with the magnetic-scrolls utility, and then run dMagnetic -vmode sixel name-of-game:

Works well, no issues as far as I can see.

bropines · 2022-11-07T22:16:00Z

Either I'm stupid, or for some reason nothing works for me

TomJo2000 · 2022-11-07T22:18:28Z

Make sure you are running one of the latest GitHub CI builds, Sixel support isn't in the stable release yet.

bropines · 2022-11-07T22:20:27Z

I literally just installed it. It used to work fine on one of the versions, but after a certain point, that's it. Maybe I should reinstall termux from scratch?

AnonymouX47 · 2023-05-06T22:27:17Z

First of all, thank you all for your work on this! 🙏🏾

Small emulator changes:

Also eat APC sequences, not echoing to screen.

Fix CSI 14 t to give actual size

Thanks for these... been working around these for a quite a while.

In addition, setting the ws_xpixel and ws_ypixel members of the winsize struct used by the TIOCGWINSZ ioctl will be very useful as this method is much faster and more reliable than the CSI 14 t query.

Most importantly, I have some concerns with the last point here (from the OP):

Support iTerm2 inline image protocol (OSC 1337):

Using the same bitmap display infrastructure introduced for sixels.

Collects the image data outside of the OSC buffer.

Ignoring some parameters.

It would be greatly helpful to know what exact parameters are ignored (without having to figure it out by oneself).

I suggest that all unimplemented protocol features, protocol extensions and inconsistencies with other implementations (particularly the reference implementation by iTerm2 itself) be clearly stated and documented for the sake of developers writing software to use this protocol.

One of the major headaches in developing cross-terminal software is inconsistency in implementation of protocols/specifications... and it's sincerely quite a pain.

Talking about inconsistencies... for instance,

what happens to images when the screen is cleared?
how do images interact with text and vice versa?

Note that I'm not saying the answers to questions like these should be documented. Instead, if the answers differ from those of the reference implementation, then those differences should be documented... or better still, fixed!

This also kinda applies to the sixel implementation (maybe see this for reference/benchmarks/tests).

Once I'm able to get a working build of Termux with this branch and some time, I'll test as much as I can and give any necessary feedback.

Thanks once again 🙏🏾

MatanZ · 2023-05-08T18:27:52Z

In addition, setting the ws_xpixel and ws_ypixel members of the winsize struct used by the TIOCGWINSZ ioctl will be very useful as this method is much faster and more reliable than the CSI 14 t query.

This is in #3098.

Most importantly, I have some concerns with the last point here (from the OP):

Support iTerm2 inline image protocol (OSC 1337):

Using the same bitmap display infrastructure introduced for sixels.

Collects the image data outside of the OSC buffer.

Ignoring some parameters.

It would be greatly helpful to know what exact parameters are ignored (without having to figure it out by oneself).

Checking the code, it seems that the only ignore parameter is size, which should be meaningless for well behaved programs.

* what happens to images when the screen is cleared?

The images are also cleared.

* how do images interact with text and vice versa?

Each cell may display either a part of an image or a character. Each cell displays the last thing (text or image) printed to it. I believe this is the standard behaviour for sixel and iterm2 protocols for all terminal emulators. kitty protocol has more advanced behaviour, and cannot really be supported with the current graphics implementation.

Note that I'm not saying the answers to questions like these should be documented. Instead, if the answers differ from those of the reference implementation, then those differences should be documented... or better still, fixed!

This also kinda applies to the sixel implementation (maybe see this for reference/benchmarks/tests).

In general, I am more interested in getting current applications working than in bug to bug compatibility with 40 years old hardware. But even there I will sometimes choose a more reasonable behaviour.

For example - xterm limits sixel images to 1024 and screen width (the smaller of those). I limit to 8192 and not to screen width. This breaks lsix.

Once I'm able to get a working build of Termux with this branch and some time, I'll test as much as I can and give any necessary feedback.

If you want to run termux with this PR (and some other), without building yourself, there is https://github.com/HardcodedCat/termux-monet

AnonymouX47 · 2023-05-08T22:00:35Z

Oh, great!

If you want to run termux with this PR (and some other), without building yourself, there is https://github.com/HardcodedCat/termux-monet

Will try that out. Thanks.

ikcikoR · 2024-02-03T21:53:36Z

Is this being worked on? Can't wait for this feature but I'm seeing there has been no activity for over half a year

TomJo2000 · 2024-02-03T22:08:36Z

Is this being worked on? Can't wait for this feature but I'm seeing there has been no activity for over half a year

The feature is finished as far as I am aware and pending inclusion in a future release.
If that's not soon enough you can grab a testing APK from a CI run.

Suletta-Majo · 2024-02-04T15:39:09Z

i want. test apk or old sixel worked version ! what and called CI where is this?

edited-> CI maybe meaning continuous integration GitHub action.
hard for me :/ i selecte again monet

Kreijstal · 2024-02-14T20:22:07Z

idc if this get merged, where can I get an apk ??? o.o
me want

AnonymouX47 · 2024-02-14T21:28:40Z

@Kreijstal: https://github.com/KitsunedFox/termux-monet

Kreijstal · 2024-02-14T23:19:34Z

@Kreijstal: https://github.com/KitsunedFox/termux-monet

I uninstalled termux so fast I forgot to backup my configuration.
Doesn't matter sixel, was worth it.

AnonymouX47 · 2024-02-15T09:33:36Z

For what it's worth, I think the APK signatures are compatible. Over here, I can install one over the other (and vice versa) without loosing any data... though, I'm not sure how good an idea it is.

ikcikoR · 2024-04-02T23:47:18Z

For what it's worth, I think the APK signatures are compatible. Over here, I can install one over the other (and vice versa) without loosing any data... though, I'm not sure how good an idea it is.

Not if you got your Termux from f-droid sadly

aicynide · 2024-04-23T19:00:37Z

Waiting for kitty support

TomJo2000 · 2024-04-23T19:03:57Z

Out of scope for this PR, please do not reply to dormant threads unnecessarily.
It notifies everybody involved in the thread.

MatanZ added 2 commits September 4, 2022 19:01

\007 is bell, only if not ending APC or OSC.

35a7bb8

Add missing {} that change the logic.

Better handling of Out of Memory errors in bitmap allocations.

92dac00

- For iterm2 images - catch the error, and cancel the image. - For sixels - if it happens when resizing the bitmap, than ignore drawing outside of the current image.

Refactor bitmap code

6b46ae7

- Move working bitmap code (drawing current bitmap) to WorkingTerminalBitmap class. - Move bitmap handling code to TerminalBitmap class.

Copy the set of keys from the map before iterating.

1ce120e

To avoid removing elements from the map while iterating over it. This should solve the Concurrent Modification Exception in the bitmap garbage collection.

sylirre added a commit to termux/termux-packages that referenced this pull request Sep 8, 2022

libsixel: depend on libgd and gdk-pixbuf

b72be3c

Fixes issue with some GIFs. See my comment at termux/termux-app#2973 (comment) Also enable libcurl support.

termux-pacman-bot added a commit to termux-pacman/termux-packages that referenced this pull request Sep 8, 2022

libsixel: depend on libgd and gdk-pixbuf

dc46439

Fixes issue with some GIFs. See my comment at termux/termux-app#2973 (comment) Also enable libcurl support.

This comment was marked as off-topic.

Sign in to view

microo8 mentioned this pull request Sep 22, 2022

[Feature]: Support for CSI 14 #3002

Open

This was linked to issues Sep 24, 2022

Feature Request: sixel graphics mode #142

Open

[Feature]: Support for CSI 14 #3002

Open

agnostic-apollo force-pushed the master branch from 21804bc to 3f7a939 Compare October 3, 2022 23:49

sylirre mentioned this pull request Oct 27, 2022

[Bug]: Not working Kitty in Timg #3049

Closed

This comment was marked as spam.

Sign in to view

XOXO045 mentioned this pull request Jan 27, 2023

**terminal-view/src/main/java/com/termux/view/TerminalRenderer.java minimal-manifest-twrp/platform_manifest_twrp_lineageos#17

Open

Grimler91 mentioned this pull request Sep 2, 2023

[Package]: pic termux/termux-packages#17697

Open

1 task

TomJo2000 mentioned this pull request Apr 10, 2024

bump(main/tmux): 3.4 termux/termux-packages#19736

Merged

Add graphics in terminal support: - Sixel and iTerm2 protocols #2973

Are you sure you want to change the base?

Add graphics in terminal support: - Sixel and iTerm2 protocols #2973

Conversation

MatanZ commented Sep 4, 2022

aicynide commented Sep 5, 2022

KitsunedFox commented Sep 5, 2022

MatanZ commented Sep 6, 2022

KitsunedFox commented Sep 6, 2022

KitsunedFox commented Sep 6, 2022 • edited

Here's a small guide for anyone else who wants to test this PR

sylirre commented Sep 6, 2022 • edited

KitsunedFox commented Sep 6, 2022 • edited

cogburnd02 commented Sep 6, 2022

sylirre commented Sep 6, 2022 • edited

KitsunedFox commented Sep 6, 2022 • edited

MatanZ commented Sep 6, 2022

Here's a small guide for anyone else who wants to test this PR

KitsunedFox commented Sep 6, 2022

MatanZ commented Sep 6, 2022

agnostic-apollo commented Sep 6, 2022

MatanZ commented Sep 7, 2022

MatanZ commented Sep 7, 2022

agnostic-apollo commented Sep 7, 2022

sylirre commented Sep 7, 2022 • edited

MatanZ commented Sep 8, 2022

sylirre commented Sep 8, 2022 • edited

sylirre commented Sep 8, 2022

This comment was marked as off-topic.

This comment was marked as off-topic.

MatanZ commented Sep 18, 2022

Anonymous2716 commented Sep 20, 2022

KitsunedFox commented Sep 20, 2022 • edited

Anonymous2716 commented Sep 20, 2022 • edited

Crash Details

Stacktrace

Termux App Info

Device Info

Software

Hardware

Grimler91 commented Oct 30, 2022

bropines commented Nov 7, 2022

TomJo2000 commented Nov 7, 2022

bropines commented Nov 7, 2022

This comment was marked as spam.

AnonymouX47 commented May 6, 2023 • edited

MatanZ commented May 8, 2023

AnonymouX47 commented May 8, 2023

ikcikoR commented Feb 3, 2024

TomJo2000 commented Feb 3, 2024

Suletta-Majo commented Feb 4, 2024 • edited

Kreijstal commented Feb 14, 2024

AnonymouX47 commented Feb 14, 2024

Kreijstal commented Feb 14, 2024

AnonymouX47 commented Feb 15, 2024

ikcikoR commented Apr 2, 2024

aicynide commented Apr 23, 2024

TomJo2000 commented Apr 23, 2024

KitsunedFox commented Sep 6, 2022 •

edited

sylirre commented Sep 6, 2022 •

edited

KitsunedFox commented Sep 6, 2022 •

edited

sylirre commented Sep 6, 2022 •

edited

KitsunedFox commented Sep 6, 2022 •

edited

sylirre commented Sep 7, 2022 •

edited

sylirre commented Sep 8, 2022 •

edited

KitsunedFox commented Sep 20, 2022 •

edited

Anonymous2716 commented Sep 20, 2022 •

edited

AnonymouX47 commented May 6, 2023 •

edited

Suletta-Majo commented Feb 4, 2024 •

edited