Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust screen width breakpoints and misc fixes #1063

Merged
merged 14 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/layouts/container.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
}

.ArticleContainer :global(.toc):not(.advanced-features) ~ .ContentContainer {
padding-right: calc(226px + 2rem);
@apply pr-64 3xl:pr-72;
}
}
7 changes: 7 additions & 0 deletions components/navigation/navItem.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,20 @@
@apply flex items-center p-2 mr-4 xl:mr-4 mb-0 rounded-md;
}

/* Design pass needed.
Centering the text under the icons when condensed creates misalignment.
Either complete the details for center alignment, or remove this to leave it left
justified. The condensed menu requires hover to expand, which isn't mobile-friendly.*/

/*
.CondensedHeadingContainer {
@apply lg:flex-wrap lg:justify-center lg:text-center lg:w-min;
}

.CondensedHeadingIconContainer {
@apply lg:mr-0;
}
*/

.Icon {
@apply text-white !important;
Expand Down
2 changes: 1 addition & 1 deletion components/utilities/breadCrumbs.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

:global(.dark) .Link {
@apply text-gray-50 !important;
@apply text-gray-70 !important;
}

.Separator {
Expand Down
4 changes: 2 additions & 2 deletions components/utilities/floatingNav.module.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.ListContainer {
@apply absolute right-0 top-0 h-full w-56 z-10 hidden;
@apply absolute right-0 top-0 h-full w-56 z-10 hidden 3xl:w-64;
}

.List {
Expand Down Expand Up @@ -27,7 +27,7 @@

/* Styles for the active item on the floating nav */
.Link {
@apply border-none inline-block pr-2 w-40 leading-4 hover:opacity-70 hover:no-underline;
@apply border-none inline-block pr-2 w-40 leading-4 hover:opacity-70 hover:no-underline 3xl:w-48;
@apply text-gray-70 !important;
}

Expand Down
7 changes: 2 additions & 5 deletions components/utilities/themeToggle.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import styles from "./themeToggle.module.css";
const ThemeToggle = () => {
const [activeTheme, setActiveTheme] = useState("light");
let inactiveTheme;
inactiveTheme = activeTheme === "light" ? "dark" : "light";

const getUserPreference = () => {
if (window.localStorage.getItem("theme")) {
Expand All @@ -16,11 +17,7 @@ const ThemeToggle = () => {
};

const changeTailwindTheme = (theme) => {
if (theme === "dark") {
inactiveTheme = "light";
} else {
inactiveTheme = "dark";
}
inactiveTheme = theme === "light" ? "dark" : "light";
document.documentElement.classList.add(theme);
document.documentElement.classList.remove(inactiveTheme);
setActiveTheme(theme);
Expand Down
1 change: 1 addition & 0 deletions tailwind.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = {
lg: "1024px",
xl: "1280px",
"2xl": "1448px",
"3xl": "1600px",
},
fontFamily: {
sans: [
Expand Down