Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust screen width breakpoints and misc fixes #1063

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

sfc-gh-dmatthews
Copy link
Contributor

@sfc-gh-dmatthews sfc-gh-dmatthews commented May 15, 2024

馃摎 Context

As screen sizes grow larger, comfortable page widths increase. This PR adds a few more break points/screen sizes to increase the maximum page width.

馃 Description of Changes

  • Added "3xl" screen sizes. The body of the page and the table of contents will increase in width at "3xl."
  • Fixed alignment of left navigation in a narrow band between "lg" and "xl" screens. This is about restoring alignment within the original design, but the "condensed" menu that exists between 1024px and 1250px screen width needs refinement.
  • Fixed hover text on theme mode selector (now shows the name of the mode to switch to).
  • Fixed breadcrumb contrast in dark mode.

New:
image
image
image

Previous:
image
image
image

馃寪 References

Notion project: Docs papercut: Alignment of left navigation

Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-dmatthews
Copy link
Contributor Author

sfc-gh-dmatthews commented May 16, 2024

Looking again, "4xl" pages are probably too wide when there isn't a TOC. That size looks okay on "full" pages, but it's too stretched on when there's no TOC. Maybe I can take off that largest size and only introduce the "3xl" for now?

/develop/concepts/architecture/widget-behavior looks okay at the "4xl" breakpoint, but the homepage is too stretched without a TOC on the right.

@sfc-gh-dmatthews sfc-gh-dmatthews changed the title Adjust screen width breakpoints and associated style fixes Adjust screen width breakpoints and misc style fixes May 29, 2024
@sfc-gh-dmatthews sfc-gh-dmatthews changed the title Adjust screen width breakpoints and misc style fixes Adjust screen width breakpoints and misc fixes May 29, 2024
@sfc-gh-dmatthews sfc-gh-dmatthews merged commit 22277ca into main Jun 11, 2024
5 checks passed
@sfc-gh-dmatthews sfc-gh-dmatthews deleted the screen-width-settings branch June 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants