WIP: fix: Flaky "__test is not defined" issue #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
valentinpalkovic
force-pushed
the
fix-flaky-__test-undefined-error
branch
from
b615d3e
to
a831a6b
Compare
valentinpalkovic
force-pushed
the
fix-flaky-__test-undefined-error
branch
from
d0c6d39
to
87422b5
Compare
|
Why was this closed instead of merged? |
|
It turned out that the flakiness was coming from somewhere else. And this PR actually didn't fix the issue. |
|
Is there another way to fix the flakiness? See the referred issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #68
📦 Published PR as canary version:
0.1.1--canary.110.87422b5.0✨ Test out this PR locally via: