fix: Flaky "__test is not defined" issue

fixes #68
storybookjs · May 23, 2022 · a831a6b · a831a6b
1 parent 62a6d5e
commit a831a6b
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/src/playwright/transformPlaywright.test.ts b/src/playwright/transformPlaywright.test.ts
@@ -77,6 +77,11 @@ describe('Playwright', () => {
  await global.__sbPreRender(page, context);
  }
  
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn
@@ -148,6 +153,11 @@ describe('Playwright', () => {
  await global.__sbPreRender(page, context);
  }
  
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn
@@ -220,6 +230,11 @@ describe('Playwright', () => {
  await global.__sbPreRender(page, context);
  }
  
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn

diff --git a/src/playwright/transformPlaywright.ts b/src/playwright/transformPlaywright.ts
@@ -25,6 +25,12 @@ export const testPrefixer = template(
  await global.__sbPreRender(page, context);
  }
 
+ await new Promise((resolve) => {
+ page.on('load', () => {
+ resolve()
+ })
+ })
+
  const result = await page.evaluate(({ id, hasPlayFn }) => __test(id, hasPlayFn), {
  id: %%id%%,
  });

diff --git a/src/playwright/transformPlaywrightJson.test.ts b/src/playwright/transformPlaywrightJson.test.ts
@@ -72,6 +72,11 @@ describe('Playwright Json', () => {
  await global.__sbPreRender(page, context);
  }
 
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn
@@ -121,6 +126,11 @@ describe('Playwright Json', () => {
  await global.__sbPreRender(page, context);
  }
 
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn
@@ -172,6 +182,11 @@ describe('Playwright Json', () => {
  await global.__sbPreRender(page, context);
  }
 
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn
@@ -261,6 +276,11 @@ describe('Playwright Json', () => {
  await global.__sbPreRender(page, context);
  }
 
+ await new Promise(resolve => {
+ page.on('load', () => {
+ resolve();
+ });
+ });
  const result = await page.evaluate(({
  id,
  hasPlayFn